From: Herbert Xu <herbert@gondor.apana.org.au>
To: Antony Antony <antony.antony@secunet.com>
Cc: "Steffen Klassert" <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, "Stephan Müller" <smueller@chronox.de>,
"Antony Antony" <antony@phenome.org>
Subject: Re: [PATCH ipsec-next] xfrm: add /proc/sys/core/net/xfrm_redact_secret
Date: Wed, 29 Jul 2020 02:22:52 +1000 [thread overview]
Message-ID: <20200728162252.GA3255@gondor.apana.org.au> (raw)
In-Reply-To: <20200728154342.GA31835@moon.secunet.de>
On Tue, Jul 28, 2020 at 05:47:30PM +0200, Antony Antony wrote:
> when enabled, 1, redact XFRM SA secret in the netlink response to
> xfrm_get_sa() or dump all sa.
>
> e.g
> echo 1 > /proc/sys/net/core/xfrm_redact_secret
> ip xfrm state
> src 172.16.1.200 dst 172.16.1.100
> proto esp spi 0x00000002 reqid 2 mode tunnel
> replay-window 0
> aead rfc4106(gcm(aes)) 0x0000000000000000000000000000000000000000 96
>
> the aead secret is redacted.
>
> /proc/sys/core/net/xfrm_redact_secret is a toggle.
> Once enabled, either at compile or via proc, it can not be disabled.
> Redacting secret is a FIPS 140-2 requirement.
Couldn't you use the existing fips_enabled sysctl?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-07-28 16:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 15:47 [PATCH ipsec-next] xfrm: add /proc/sys/core/net/xfrm_redact_secret Antony Antony
2020-07-28 16:22 ` Herbert Xu [this message]
2020-07-28 18:36 ` Antony Antony
2020-07-28 19:09 ` Stephan Mueller
2020-08-20 10:53 ` Antony Antony
2020-08-20 12:04 ` [PATCH ipsec-next v2] " Antony Antony
2020-08-20 15:10 ` Jakub Kicinski
2020-08-20 15:14 ` Nicolas Dichtel
2020-08-20 18:35 ` [PATCH ipsec-next v3] " Antony Antony
2020-08-20 22:42 ` David Miller
2020-08-24 6:00 ` Antony Antony
2020-08-27 20:15 ` Antony Antony
2020-08-27 20:20 ` David Miller
2020-10-16 13:36 ` [PATCH] xfrm: redact SA secret with lockdown confidentiality Antony Antony
2020-10-31 10:49 ` Steffen Klassert
2020-11-17 16:46 ` Antony Antony
2020-11-17 16:47 ` [PATCH ipsec-next v5] " Antony Antony
2020-11-23 6:42 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728162252.GA3255@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=antony.antony@secunet.com \
--cc=antony@phenome.org \
--cc=netdev@vger.kernel.org \
--cc=smueller@chronox.de \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.