From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Steve Longerbeam <slongerbeam@gmail.com>,
linux-media@vger.kernel.org,
Hugues Fruchet <hugues.fruchet@st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 2/2] media: i2c: ov5640: Add support for BT656 mode
Date: Fri, 31 Jul 2020 18:23:54 +0300 [thread overview]
Message-ID: <20200731152353.GS13316@paasikivi.fi.intel.com> (raw)
In-Reply-To: <1596187487-31403-3-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
On Fri, Jul 31, 2020 at 10:24:47AM +0100, Lad Prabhakar wrote:
> @@ -2875,8 +2891,10 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable)
>
> if (sensor->ep.bus_type == V4L2_MBUS_CSI2_DPHY)
> ret = ov5640_set_stream_mipi(sensor, enable);
> - else
> + else if (sensor->ep.bus_type == V4L2_MBUS_PARALLEL)
> ret = ov5640_set_stream_dvp(sensor, enable);
> + else
> + ret = ov5640_set_stream_bt656(sensor, enable);
I'd also check for the Bt.656 mode here, rather than assuming it.
Could you also update the DT bindings, given that the sensor appears to
support Bt.656 as well? I believe this requires the bus-type property, too.
>
> if (!ret)
> sensor->streaming = enable;
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2020-07-31 15:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 9:24 [PATCH 0/2] media: ov5640 feature enhancement and fixes Lad Prabhakar
2020-07-31 9:24 ` [PATCH 1/2] media: i2c: ov5640: Enable data pins on startup for DVP mode Lad Prabhakar
2020-07-31 13:03 ` Sakari Ailus
2020-07-31 13:18 ` Lad, Prabhakar
2020-07-31 15:19 ` Sakari Ailus
2020-07-31 15:23 ` Lad, Prabhakar
2020-07-31 15:31 ` Laurent Pinchart
2020-08-01 8:51 ` Lad, Prabhakar
2020-07-31 15:27 ` Laurent Pinchart
2020-08-01 8:46 ` Lad, Prabhakar
2020-07-31 9:24 ` [PATCH 2/2] media: i2c: ov5640: Add support for BT656 mode Lad Prabhakar
2020-07-31 15:23 ` Sakari Ailus [this message]
2020-07-31 15:28 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731152353.GS13316@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=hugues.fruchet@st.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.