From: SeongJae Park <sjpark@amazon.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: SeongJae Park <sjpark@amazon.com>,
SeongJae Park <sjpark@amazon.de>, <Jonathan.Cameron@Huawei.com>,
<aarcange@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
<benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
<brendanhiggins@google.com>, <cai@lca.pw>,
<colin.king@canonical.com>, <corbet@lwn.net>, <david@redhat.com>,
<dwmw@amazon.com>, <fan.du@intel.com>, <foersleo@amazon.de>,
<gthelen@google.com>, <irogers@google.com>, <jolsa@redhat.com>,
<kirill@shutemov.name>, <mark.rutland@arm.com>, <mgorman@suse.de>,
<minchan@kernel.org>, <mingo@redhat.com>, <namhyung@kernel.org>,
<peterz@infradead.org>, <rdunlap@infradead.org>,
<riel@surriel.com>, <rientjes@google.com>, <rppt@kernel.org>,
<sblbir@amazon.com>, <shakeelb@google.com>, <shuah@kernel.org>,
<sj38.park@gmail.com>, <snu@amazon.de>, <vbabka@suse.cz>,
<vdavydov.dev@gmail.com>, <yang.shi@linux.alibaba.com>,
<ying.huang@intel.com>, <linux-damon@amazon.com>,
<linux-mm@kvack.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v19 08/15] mm/damon: Add a tracepoint
Date: Wed, 5 Aug 2020 08:23:05 +0200 [thread overview]
Message-ID: <20200805062305.9417-1-sjpark@amazon.com> (raw)
In-Reply-To: <20200804180147.16d34809@oasis.local.home>
On Tue, 4 Aug 2020 18:01:47 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 4 Aug 2020 11:14:09 +0200
> SeongJae Park <sjpark@amazon.com> wrote:
>
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > This commit adds a tracepoint for DAMON. It traces the monitoring
> > results of each region for each aggregation interval. Using this, DAMON
> > can easily integrated with tracepoints supporting tools such as perf.
> >
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > Reviewed-by: Leonard Foerster <foersleo@amazon.de>
> > ---
> > include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++
> > mm/damon.c | 4 ++++
> > 2 files changed, 47 insertions(+)
> > create mode 100644 include/trace/events/damon.h
> >
[...]
> > --- a/mm/damon.c
> > +++ b/mm/damon.c
> > @@ -20,6 +20,8 @@
> >
> > #define pr_fmt(fmt) "damon: " fmt
> >
> > +#define CREATE_TRACE_POINTS
> > +
> > #include <linux/damon.h>
> > #include <linux/delay.h>
> > #include <linux/kthread.h>
> > @@ -31,6 +33,7 @@
> > #include <linux/sched/mm.h>
> > #include <linux/sched/task.h>
> > #include <linux/slab.h>
>
> It's best to place the #define CREATE_TRACE_POINTS here, so that it
> doesn't cause any side effects when including the other headers.
Agreed, I will do so in the next spin!
>
> Other than that:
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> -- Steve
Thanks,
SeongJae Park
next prev parent reply other threads:[~2020-08-05 6:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 9:14 [PATCH v19 00/15] Introduce Data Access MONitor (DAMON) SeongJae Park
2020-08-04 9:14 ` [PATCH v19 01/15] mm: " SeongJae Park
2020-08-04 9:14 ` [PATCH v19 02/15] mm/damon: Implement region based sampling SeongJae Park
2020-08-14 9:29 ` SeongJae Park
2020-08-04 9:14 ` [PATCH v19 03/15] mm/damon: Adaptively adjust regions SeongJae Park
2020-08-04 9:14 ` [PATCH v19 04/15] mm/damon: Track dynamic monitoring target regions update SeongJae Park
2020-08-04 9:14 ` [PATCH v19 05/15] mm/idle_page_tracking: Make PG_(idle|young) reusable SeongJae Park
2020-08-04 9:14 ` [PATCH v19 06/15] mm/damon: Implement callbacks for the virtual memory address spaces SeongJae Park
2020-08-04 9:14 ` [PATCH v19 07/15] mm/damon: Implement access pattern recording SeongJae Park
2020-08-04 9:14 ` [PATCH v19 08/15] mm/damon: Add a tracepoint SeongJae Park
2020-08-04 22:01 ` Steven Rostedt
2020-08-05 6:23 ` SeongJae Park [this message]
2020-08-04 9:14 ` [PATCH v19 09/15] mm/damon: Implement a debugfs interface SeongJae Park
2020-08-10 7:41 ` SeongJae Park
2020-08-04 9:14 ` [PATCH v19 10/15] damon/debugfs: Support pidfd target id SeongJae Park
2020-08-04 9:14 ` [PATCH v19 11/15] tools: Introduce a minimal user-space tool for DAMON SeongJae Park
2020-08-04 9:14 ` [PATCH v19 12/15] Documentation: Add documents " SeongJae Park
2020-08-04 9:14 ` [PATCH v19 13/15] mm/damon: Add kunit tests SeongJae Park
2020-08-04 9:14 ` [PATCH v19 14/15] mm/damon: Add user space selftests SeongJae Park
2020-08-04 9:14 ` [PATCH v19 15/15] MAINTAINERS: Update for DAMON SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805062305.9417-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendan.d.gregg@gmail.com \
--cc=brendanhiggins@google.com \
--cc=cai@lca.pw \
--cc=colin.king@canonical.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=gthelen@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kirill@shutemov.name \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sblbir@amazon.com \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=snu@amazon.de \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.