Re: [PATCH v9 1/2] iio: humidity: Add TI HDC20x0 support

From: Jonathan Cameron <jic23@kernel.org>
To: Eugene Zaikonnikov <ez@norphonic.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	development@norphonic.com, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v9 1/2] iio: humidity: Add TI HDC20x0 support
Date: Thu, 6 Aug 2020 19:46:26 +0100	[thread overview]
Message-ID: <20200806194626.6e7b2545@archlinux> (raw)
In-Reply-To: <86zh7ak8ub.fsf@norphonic.com>

On Tue, 04 Aug 2020 12:23:56 +0200
Eugene Zaikonnikov <ez@norphonic.com> wrote:

> Hello,
> 
> Jonathan Cameron <jic23@kernel.org> writes:
> 
> > On Sat, 11 Jul 2020 18:27:09 +0300
> > Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> >  
> 
> [...]
> 
> >> 4. IIO_CONST_ATTR can be one line, but hey don't we have IIO core to
> >> take care of it?  
> >
> > For that one, we could indeed use the read_avail callback here
> > for the out_current_heater_raw_available. I've not yet started insisting
> > on this because of the huge number of drivers that predate introduction of
> > that stuff to the core and as a result a lack of good examples.
> > Eugene, if you are happy to change this one over to that and hence act
> > as an example it would be great!
> >  
> Just looked into that.
> 
> We use this driver here with trees as early as 4.9.11, and it does not
> appear to have this callback in iio_info yet. Hope it's OK as it is in
> this iteration.
OK.   It is more than possible that someone will post patches tidying
that up though and I'm not going to reject them to make life easier
for your older trees.  For now, put a note in the commit log though
so I don't forget it.

Thanks,

Jonathan

> 
> --
> Regards,
> 
>   Eugene Zaikonnikov
> 
>   Norphonic AS
>   Tel: +47 98 23 97 73