All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
Date: Thu, 13 Aug 2020 23:41:48 +0800	[thread overview]
Message-ID: <202008132358.fOIZ2tMp%lkp@intel.com> (raw)
In-Reply-To: <20200813083644.31711-21-tzimmermann@suse.de>

[-- Attachment #1: Type: text/plain, Size: 3744 bytes --]

Hi Thomas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on next-20200813]
[cannot apply to drm-intel/for-linux-next linux-arm/drm-armada-devel linux-arm/drm-armada-fixes anholt/for-next v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200813-163944
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dc06fe51d26efc100ac74121607c01a454867c91
config: i386-randconfig-m021-20200811 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
drivers/gpu/drm/drm_prime.c:389 export_and_register_object() error: uninitialized symbol 'dmabuf'.

Old smatch warnings:
drivers/gpu/drm/drm_prime.c:359 drm_gem_prime_fd_to_handle() warn: inconsistent returns 'dev->object_name_lock'.

vim +/dmabuf +389 drivers/gpu/drm/drm_prime.c

89177644a7b6306 Aaron Plattner 2013-01-15  374  
319c933c71f3dbd Daniel Vetter  2013-08-15  375  static struct dma_buf *export_and_register_object(struct drm_device *dev,
319c933c71f3dbd Daniel Vetter  2013-08-15  376  						  struct drm_gem_object *obj,
319c933c71f3dbd Daniel Vetter  2013-08-15  377  						  uint32_t flags)
319c933c71f3dbd Daniel Vetter  2013-08-15  378  {
319c933c71f3dbd Daniel Vetter  2013-08-15  379  	struct dma_buf *dmabuf;
319c933c71f3dbd Daniel Vetter  2013-08-15  380  
319c933c71f3dbd Daniel Vetter  2013-08-15  381  	/* prevent races with concurrent gem_close. */
319c933c71f3dbd Daniel Vetter  2013-08-15  382  	if (obj->handle_count == 0) {
319c933c71f3dbd Daniel Vetter  2013-08-15  383  		dmabuf = ERR_PTR(-ENOENT);
319c933c71f3dbd Daniel Vetter  2013-08-15  384  		return dmabuf;
319c933c71f3dbd Daniel Vetter  2013-08-15  385  	}
319c933c71f3dbd Daniel Vetter  2013-08-15  386  
b39b5394fabc79a Noralf Trønnes 2018-11-10  387  	if (obj->funcs && obj->funcs->export)
b39b5394fabc79a Noralf Trønnes 2018-11-10  388  		dmabuf = obj->funcs->export(obj, flags);
319c933c71f3dbd Daniel Vetter  2013-08-15 @389  	if (IS_ERR(dmabuf)) {
319c933c71f3dbd Daniel Vetter  2013-08-15  390  		/* normally the created dma-buf takes ownership of the ref,
319c933c71f3dbd Daniel Vetter  2013-08-15  391  		 * but if that fails then drop the ref
319c933c71f3dbd Daniel Vetter  2013-08-15  392  		 */
319c933c71f3dbd Daniel Vetter  2013-08-15  393  		return dmabuf;
319c933c71f3dbd Daniel Vetter  2013-08-15  394  	}
319c933c71f3dbd Daniel Vetter  2013-08-15  395  
319c933c71f3dbd Daniel Vetter  2013-08-15  396  	/*
319c933c71f3dbd Daniel Vetter  2013-08-15  397  	 * Note that callers do not need to clean up the export cache
319c933c71f3dbd Daniel Vetter  2013-08-15  398  	 * since the check for obj->handle_count guarantees that someone
319c933c71f3dbd Daniel Vetter  2013-08-15  399  	 * will clean it up.
319c933c71f3dbd Daniel Vetter  2013-08-15  400  	 */
319c933c71f3dbd Daniel Vetter  2013-08-15  401  	obj->dma_buf = dmabuf;
319c933c71f3dbd Daniel Vetter  2013-08-15  402  	get_dma_buf(obj->dma_buf);
319c933c71f3dbd Daniel Vetter  2013-08-15  403  
319c933c71f3dbd Daniel Vetter  2013-08-15  404  	return dmabuf;
319c933c71f3dbd Daniel Vetter  2013-08-15  405  }
319c933c71f3dbd Daniel Vetter  2013-08-15  406  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30687 bytes --]

  parent reply	other threads:[~2020-08-13 15:41 UTC|newest]

Thread overview: 243+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  8:36 [PATCH 00/20] Convert all remaining drivers to GEM object functions Thomas Zimmermann
2020-08-13  8:36 ` Thomas Zimmermann
2020-08-13  8:36 ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36 ` Thomas Zimmermann
2020-08-13  8:36 ` Thomas Zimmermann
2020-08-13  8:36 ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 01/20] drm/amdgpu: Introduce " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 10:22   ` Christian König
2020-08-13 10:22     ` Christian König
2020-08-13 10:22     ` [Intel-gfx] " Christian König
2020-08-13 10:22     ` Christian König
2020-08-13 10:22     ` Christian König
2020-08-13 10:22     ` Christian König
2020-08-13 10:22     ` Christian König
2020-09-14 15:05     ` Thomas Zimmermann
2020-09-14 15:05       ` Thomas Zimmermann
2020-09-14 15:05       ` [Intel-gfx] " Thomas Zimmermann
2020-09-14 15:05       ` Thomas Zimmermann
2020-09-14 15:05       ` Thomas Zimmermann
2020-09-14 15:05       ` Thomas Zimmermann
2020-09-14 15:05       ` Thomas Zimmermann
     [not found]       ` <c445493b-9914-63f2-1cf2-c3c1de14e3e5-l3A5Bk7waGM@public.gmane.org>
2020-09-14 17:51         ` Christian König
2020-09-14 17:51           ` Christian König
2020-09-14 17:51           ` Christian König
2020-09-14 17:51           ` [Intel-gfx] " Christian König
2020-09-14 17:51           ` Christian König
2020-08-13  8:36 ` [PATCH 02/20] drm/armada: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 03/20] drm/etnaviv: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 04/20] drm/exynos: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 05/20] drm/gma500: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 06/20] drm/i915: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  9:08   ` Jani Nikula
2020-08-13  9:08     ` Jani Nikula
2020-08-13  9:08     ` [Intel-gfx] " Jani Nikula
2020-08-13  9:08     ` Jani Nikula
2020-08-13  9:08     ` Jani Nikula
2020-08-13  9:08     ` Jani Nikula
2020-08-13  9:13     ` Thomas Zimmermann
2020-08-13  9:13       ` Thomas Zimmermann
2020-08-13  9:13       ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  9:13       ` Thomas Zimmermann
2020-08-13  9:13       ` Thomas Zimmermann
2020-08-13  9:13       ` Thomas Zimmermann
2020-08-13  9:13       ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 07/20] drm/mediatek: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 08/20] drm/msm: Introduce GEM object funcs Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 09/20] drm/nouveau: Introduce GEM object functions Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 10/20] drm/omapdrm: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 13:38   ` Laurent Pinchart
2020-08-13 13:38     ` Laurent Pinchart
2020-08-13 13:38     ` [Intel-gfx] " Laurent Pinchart
2020-08-13 13:38     ` Laurent Pinchart
2020-08-13 13:38     ` Laurent Pinchart
2020-08-13 13:38     ` Laurent Pinchart
2020-08-13 13:38     ` Laurent Pinchart
2020-08-19 10:43   ` Tomi Valkeinen
2020-08-19 10:43     ` Tomi Valkeinen
2020-08-19 10:43     ` [Intel-gfx] " Tomi Valkeinen
2020-08-19 10:43     ` Tomi Valkeinen
2020-08-19 10:43     ` Tomi Valkeinen
2020-08-19 10:43     ` Tomi Valkeinen
2020-08-19 10:43     ` Tomi Valkeinen
2020-08-13  8:36 ` [PATCH 11/20] drm/pl111: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 12/20] drm/radeon: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 10:24   ` Christian König
2020-08-13 10:24     ` Christian König
2020-08-13 10:24     ` [Intel-gfx] " Christian König
2020-08-13 10:24     ` Christian König
2020-08-13 10:24     ` Christian König
2020-08-13 10:24     ` Christian König
2020-08-13 10:24     ` Christian König
2020-08-13 10:41     ` Thomas Zimmermann
2020-08-13 10:41       ` Thomas Zimmermann
2020-08-13 10:41       ` [Intel-gfx] " Thomas Zimmermann
2020-08-13 10:41       ` Thomas Zimmermann
2020-08-13 10:41       ` Thomas Zimmermann
2020-08-13 10:41       ` Thomas Zimmermann
2020-08-13 10:41       ` Thomas Zimmermann
2020-08-13 10:47       ` Christian König
2020-08-13 10:47         ` Christian König
2020-08-13 10:47         ` [Intel-gfx] " Christian König
2020-08-13 10:47         ` Christian König
2020-08-13 10:47         ` Christian König
2020-08-13 10:47         ` Christian König
2020-08-13 10:47         ` Christian König
2020-08-13  8:36 ` [PATCH 13/20] drm/rockchip: Convert to drm_gem_object_funcs Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 11:26   ` [Intel-gfx] " kernel test robot
2020-08-13  8:36 ` [PATCH 14/20] drm/tegra: Introduce GEM object functions Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 15/20] drm/vc4: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 16/20] drm/vgem: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 17/20] drm/vkms: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 18/20] drm/xen: " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 11:19   ` Oleksandr Andrushchenko
2020-08-13 11:19     ` Oleksandr Andrushchenko
2020-08-13 11:19     ` Oleksandr Andrushchenko
2020-08-13 11:19     ` [Intel-gfx] " Oleksandr Andrushchenko
2020-08-13 11:19     ` Oleksandr Andrushchenko
2020-08-13 11:19     ` Oleksandr Andrushchenko
2020-08-13 11:19     ` Oleksandr Andrushchenko
2020-09-15  8:56     ` Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-09-15  8:56       ` [Intel-gfx] " Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-09-15  8:56       ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 19/20] drm/xlnx: Initialize DRM driver instance with CMA helper macro Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 13:36   ` Laurent Pinchart
2020-08-13 13:36     ` Laurent Pinchart
2020-08-13 13:36     ` [Intel-gfx] " Laurent Pinchart
2020-08-13 13:36     ` Laurent Pinchart
2020-08-13 13:36     ` Laurent Pinchart
2020-08-13 13:36     ` Laurent Pinchart
2020-08-13 13:36     ` Laurent Pinchart
2020-08-13 13:57     ` Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13 13:57       ` [Intel-gfx] " Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13 13:57       ` Thomas Zimmermann
2020-08-13  8:36 ` [PATCH 20/20] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` [Intel-gfx] " Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13  8:36   ` Thomas Zimmermann
2020-08-13 10:16   ` Sam Ravnborg
2020-08-13 10:16     ` Sam Ravnborg
2020-08-13 10:16     ` [Intel-gfx] " Sam Ravnborg
2020-08-13 10:16     ` Sam Ravnborg
2020-08-13 10:16     ` Sam Ravnborg
2020-08-13 10:16     ` Sam Ravnborg
2020-08-13 10:16     ` Sam Ravnborg
2020-08-13 10:33     ` Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 10:33       ` [Intel-gfx] " Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 10:33       ` Thomas Zimmermann
2020-08-13 12:45   ` [Intel-gfx] " kernel test robot
2020-08-13 15:41   ` kernel test robot [this message]
2020-08-13  9:30 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Convert all remaining drivers to GEM object functions Patchwork
2020-08-13  9:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008132358.fOIZ2tMp%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.