From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH 1/5] Makefile: drop builtins from MSVC pdb list
Date: Fri, 14 Aug 2020 10:32:31 -0400 [thread overview]
Message-ID: <20200814143231.GA4167031@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2008141611490.54@tvgsbejvaqbjf.bet>
On Fri, Aug 14, 2020 at 04:18:37PM +0200, Johannes Schindelin wrote:
> While all four methods work, the only one that is regularly used with the
> `make install` command is the first one.
>
> The location you modified is in the `MSVC` part of `compat.mak.uname`,
> i.e. in the Visual C part.
>
> We originally had a tentative plan to eventually, maybe, build Git for
> Windows using Visual C by default. However, it turned out that the
> standard malloc in Visual C's runtime was tuned for other workloads than
> Gits, and that nedmalloc performed better, and we originally could not get
> nedmalloc to compile with a modern Visual C, so we stopped that effort.
>
> That's why you still have support for `make MSVC=1 install`.
>
> Since it seems not to be too much trouble, I would prefer to keep it
> working for now, even if it is rarely exercised and regressions might
> creep in (like the ones you fixed).
Ah, thanks. That perfectly explains what is going on and why it might
not have been noticed. I agree it is not too much trouble to keep it
around for now.
-Peff
next prev parent reply other threads:[~2020-08-14 14:32 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 14:55 [PATCH 0/5] slimming down installed size Jeff King
2020-08-13 14:57 ` [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Jeff King
2020-08-13 15:04 ` Taylor Blau
2020-08-13 15:08 ` Jeff King
2020-08-13 16:37 ` Derrick Stolee
2020-08-13 17:40 ` Jeff King
2020-08-14 14:18 ` Johannes Schindelin
2020-08-14 14:32 ` Jeff King [this message]
2020-08-17 4:42 ` Johannes Schindelin
2020-08-17 13:20 ` Jeff Hostetler
2020-08-13 14:58 ` [PATCH 2/5] make credential helpers builtins Jeff King
2020-08-13 15:08 ` Taylor Blau
2020-08-13 15:14 ` Jeff King
2020-08-13 17:55 ` Junio C Hamano
2020-08-13 14:59 ` [PATCH 3/5] make git-bugreport a builtin Jeff King
2020-08-13 17:01 ` Derrick Stolee
2020-08-13 17:38 ` Jeff King
2020-08-13 18:25 ` Junio C Hamano
2020-08-13 18:47 ` Junio C Hamano
2020-08-14 10:13 ` Jeff King
2020-08-14 14:25 ` Johannes Schindelin
2020-08-14 10:05 ` Jeff King
2020-08-13 18:01 ` Junio C Hamano
2020-08-14 14:28 ` Johannes Schindelin
2020-08-15 6:38 ` Jeff King
2020-08-17 12:12 ` Emily Shaffer
2020-08-17 16:58 ` Junio C Hamano
2020-08-17 21:40 ` Jeff King
2020-08-17 12:16 ` Emily Shaffer
2020-08-13 14:59 ` [PATCH 4/5] make git-fast-import " Jeff King
2020-08-13 15:00 ` [PATCH 5/5] drop vcs-svn experiment Jeff King
2020-08-13 15:11 ` Taylor Blau
2020-08-13 15:18 ` Jeff King
2020-08-14 14:39 ` Johannes Schindelin
2020-08-14 15:11 ` Jeff King
2020-08-13 15:13 ` [PATCH 0/5] slimming down installed size Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814143231.GA4167031@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.