From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
tiwai@suse.de,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
vinod.koul@intel.com, broonie@kernel.org,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>
Subject: [PATCH 07/14] ASoC: codecs: max98373-sdw: add missing test on resume
Date: Fri, 21 Aug 2020 14:55:54 -0500 [thread overview]
Message-ID: <20200821195603.215535-8-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200821195603.215535-1-pierre-louis.bossart@linux.intel.com>
All existing SoundWire codecs follow the same pattern on resume,
except for this codec which doesn't test if the hardware is
initialized.
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/max98373-sdw.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/max98373-sdw.c b/sound/soc/codecs/max98373-sdw.c
index 5fe724728e84..6469612c42cb 100644
--- a/sound/soc/codecs/max98373-sdw.c
+++ b/sound/soc/codecs/max98373-sdw.c
@@ -256,6 +256,9 @@ static __maybe_unused int max98373_resume(struct device *dev)
struct max98373_priv *max98373 = dev_get_drvdata(dev);
unsigned long time;
+ if (!max98373->hw_init)
+ return 0;
+
if (!slave->unattach_request)
goto regmap_sync;
--
2.25.1
next prev parent reply other threads:[~2020-08-21 20:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 19:55 [PATCH 00/14] ASoC: Intel: machine driver updates for 5.10 Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 01/14] ASoC: Intel: modify SoundWire version id in acpi match table Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 02/14] ASoC: Intel: soc-acpi: cnl: add support for rt5682 on SoundWire link2 Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 03/14] ASoC: Intel: sof-soundwire: add support for rt5682 on link2 Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 04/14] ASoC: Intel: soc-acpi: mirror CML and TGL configurations Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 05/14] ASoC: Intel: soc-acpi: add support for SDCA boards Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 06/14] ASoC: Intel: tgl_max98373: fix a runtime pm issue in multi-thread case Pierre-Louis Bossart
2020-08-21 21:55 ` Mark Brown
2020-08-24 14:24 ` Pierre-Louis Bossart
2020-08-24 18:56 ` Mark Brown
2020-08-21 19:55 ` Pierre-Louis Bossart [this message]
2020-08-21 19:55 ` [PATCH 08/14] ASoC: Intel: sof_sdw: check SoundWire version when matching codec Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 09/14] ASoC: Intel: sof_sdw: rename id as part_id Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 10/14] ASoC: Intel: sof_sdw: Add support for product Ripto Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 10/14] SoC: " Pierre-Louis Bossart
2020-08-21 19:55 ` [PATCH 11/14] ASoC: Intel: sof_rt5682: override quirk data for tgl_max98373_rt5682 Pierre-Louis Bossart
2020-08-21 19:56 ` [PATCH 12/14] ASoC: SOF: Add topology filename override based on dmi data match Pierre-Louis Bossart
2020-08-21 19:56 ` [PATCH 13/14] ASoC: intel: sof_sdw: add rt711 rt1316 rt714 SDCA codec support Pierre-Louis Bossart
2020-08-21 19:56 ` [PATCH 13/14] ASoC: Intel: " Pierre-Louis Bossart
2020-08-21 19:56 ` [PATCH 14/14] ASoC: Intel: sof_sdw: clean-up inclusion of header files Pierre-Louis Bossart
2020-08-24 13:31 ` [PATCH 00/14] ASoC: Intel: machine driver updates for 5.10 Mark Brown
2020-08-24 19:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821195603.215535-8-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=rander.wang@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.