From: Christoph Hellwig <hch@infradead.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Ilya Dryomov <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Jeff Layton <jlayton@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] bio: introduce BIO_FOLL_PIN flag
Date: Sun, 23 Aug 2020 07:25:59 +0100 [thread overview]
Message-ID: <20200823062559.GA32480@infradead.org> (raw)
In-Reply-To: <20200822042059.1805541-5-jhubbard@nvidia.com>
On Fri, Aug 21, 2020 at 09:20:58PM -0700, John Hubbard wrote:
> Add a new BIO_FOLL_PIN flag to struct bio, whose "short int" flags field
> was full, thuse triggering an expansion of the field from 16, to 32
> bits. This allows for a nice assertion in bio_release_pages(), that the
> bio page release mechanism matches the page acquisition mechanism.
>
> Set BIO_FOLL_PIN whenever pin_user_pages_fast() is used, and check for
> BIO_FOLL_PIN before using unpin_user_page().
When would the flag not be set when BIO_NO_PAGE_REF is not set?
Also I don't think we can't just expand the flags field, but I can send
a series to kill off two flags.
next prev parent reply other threads:[~2020-08-23 6:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 4:20 [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast() John Hubbard
2020-08-22 4:20 ` [PATCH 1/5] iov_iter: introduce iov_iter_pin_user_pages*() routines John Hubbard
2020-08-22 4:20 ` [PATCH 2/5] mm/gup: introduce pin_user_page() John Hubbard
2020-08-22 4:20 ` [PATCH 3/5] bio: convert get_user_pages_fast() --> pin_user_pages_fast() John Hubbard
2020-08-22 4:20 ` [PATCH 4/5] bio: introduce BIO_FOLL_PIN flag John Hubbard
2020-08-23 6:25 ` Christoph Hellwig [this message]
2020-08-23 6:57 ` John Hubbard
2020-08-24 7:36 ` John Hubbard
2020-08-24 9:20 ` Jens Axboe
2020-08-24 14:42 ` Christoph Hellwig
2020-08-27 3:25 ` [bio] 37abbdc72e: WARNING:at_block/bio.c:#bio_release_pages kernel test robot
2020-08-27 3:25 ` kernel test robot
2020-08-27 3:25 ` [LTP] " kernel test robot
2020-08-27 3:59 ` John Hubbard
2020-08-27 3:59 ` John Hubbard
2020-08-27 3:59 ` [LTP] " John Hubbard
2020-08-22 4:20 ` [PATCH 5/5] fs/ceph: use pipe_get_pages_alloc() for pipe John Hubbard
2020-08-24 10:53 ` Jeff Layton
2020-08-24 10:53 ` Jeff Layton
2020-08-24 17:54 ` John Hubbard
2020-08-24 18:47 ` Jeff Layton
2020-08-24 18:47 ` Jeff Layton
2020-08-24 18:54 ` Matthew Wilcox
2020-08-24 19:02 ` John Hubbard
2020-08-25 1:20 ` [PATCH v2] " John Hubbard
2020-08-25 16:22 ` Jeff Layton
2020-08-25 16:22 ` Jeff Layton
2020-08-25 1:54 ` [PATCH 0/5] bio: Direct IO: convert to pin_user_pages_fast() Al Viro
2020-08-25 2:07 ` Al Viro
2020-08-25 2:13 ` John Hubbard
2020-08-25 2:07 ` John Hubbard
2020-08-25 2:22 ` Al Viro
2020-08-25 2:27 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823062559.GA32480@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.