All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Subject: [OSSTEST PATCH 06/12] duration estimator: Fix a warning
Date: Tue, 25 Aug 2020 12:40:35 +0100	[thread overview]
Message-ID: <20200825114041.16290-7-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <20200825114041.16290-1-ian.jackson@eu.citrix.com>

$onhost can be undef.  Fixes this warning:

Use of uninitialized value $onhost in concatenation (.) or string at Osstest/Executive.pm line 1293.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/Executive.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
index 4151aa6c..b3aecfc5 100644
--- a/Osstest/Executive.pm
+++ b/Osstest/Executive.pm
@@ -1274,7 +1274,8 @@ END
     return sub {
         my ($job, $hostidname, $onhost, $uptoincl_testid) = @_;
 
-	my $memokey = "$job $hostidname $onhost ".($uptoincl_testid//"");
+	my $memokey =
+	  "$job $hostidname ".($onhost//"")." ".($uptoincl_testid//"");
 	my $memo = $our_memo->{$memokey};
 	return @$memo if $memo;
 
-- 
2.20.1



  parent reply	other threads:[~2020-08-25 11:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 11:40 [OSSTEST PATCH 00/12] Miscellaneous cleanups Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 01/12] ms-queuedaemon: Update for newer Tcl's socket channel ids Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 02/12] Executive.pm planner: fix typo Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 03/12] README.planner: Document magic job hostflags Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 04/12] sg-run-job: Minor whitespace (formatting) changes Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 05/12] show_abs_time: Represent undef $timet as <undef> Ian Jackson
2020-08-25 11:40 ` Ian Jackson [this message]
2020-08-25 11:40 ` [OSSTEST PATCH 07/12] ts-hosts-allocate-Executive: Add a comment about a warning Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 08/12] target setup refactoring: Move target_kernkind_check Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 09/12] target setup refactoring: Move target_kernkind_console_inittab Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 10/12] target setup refactoring: Merge target_kernkind_* Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 11/12] target setup refactoring: Add a doc comment Ian Jackson
2020-08-25 11:40 ` [OSSTEST PATCH 12/12] abolish "kernkind"; desupport non-pvops kernels Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825114041.16290-7-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.