From: Jason Gunthorpe <jgg@nvidia.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Kamal Heib <kamalheib1@gmail.com>, <linux-rdma@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Zhu Yanjun <yanjunz@nvidia.com>
Subject: Re: [PATCH v4 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create()
Date: Thu, 27 Aug 2020 13:29:50 -0300 [thread overview]
Message-ID: <20200827162950.GL1152540@nvidia.com> (raw)
In-Reply-To: <47468360-cd58-96fd-7d4f-4f4c351e9ce7@acm.org>
On Thu, Aug 27, 2020 at 09:22:56AM -0700, Bart Van Assche wrote:
> On 2020-08-27 07:54, Jason Gunthorpe wrote:
> > On Thu, Aug 27, 2020 at 05:29:55PM +0300, Kamal Heib wrote:
> >>> Can you send a PR to rdma-core to delete rxe_cfg as well? In
> >>> preperation to remove the module parameters
> >>>
> >>
> >> Someone already did that :-)
> >>
> >> commit 0d2ff0e1502ebc63346bc9ffd37deb3c4fd0dbc9
> >> Author: Jason Gunthorpe <jgg@ziepe.ca>
> >> Date: Tue Jan 28 15:53:07 2020 -0400
> >>
> >> rxe: Remove rxe_cfg
> >>
> >> This is obsoleted by iproute2's 'rdma link add' command.
> >>
> >> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> >
> > Oh! Lets drop the kernel side of this in Jan 2021 then?
>
> I think the person who wants to remove the kernel side of this is responsible
> for modifying blktests such that blktests does not break. From the blktests
> source code:
Just replace the whole thing with rdma link add - it does module
autoloading and everything.
Jason
next prev parent reply other threads:[~2020-08-27 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 15:17 [PATCH v4 for-rc] RDMA/rxe: Fix panic when calling kmem_cache_create() Kamal Heib
2020-08-27 12:18 ` Jason Gunthorpe
2020-08-27 14:29 ` Kamal Heib
2020-08-27 14:39 ` Zhu Yanjun
2020-08-27 14:54 ` Jason Gunthorpe
2020-08-27 16:22 ` Bart Van Assche
2020-08-27 16:29 ` Jason Gunthorpe [this message]
2020-09-02 5:33 ` Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827162950.GL1152540@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=kamalheib1@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.