From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] generic: disable dmlogwrites tests on XFS
Date: Mon, 31 Aug 2020 17:02:14 +0100 [thread overview]
Message-ID: <20200831160214.GA6740@infradead.org> (raw)
In-Reply-To: <20200831133732.GB2667@bfoster>
On Mon, Aug 31, 2020 at 09:37:32AM -0400, Brian Foster wrote:
> Yes, but the goal of this patch is not to completely fix the dmlogwrites
> infrastructure and set of tests. The goal is to disable a subset of
> tests that are known to produce spurious corruptions on XFS until that
> issue can be addressed, so it doesn't result in continued bug reports in
> the meantime. I don't run these tests routinely on other fs', so it's
> not really my place to decide that the tradeoff between this problem and
> the ability of the test to reproduce legitimate bugs justifies disabling
> the test on those configs.
So my problem is that XFS here is the messenger - this could screw up
every other file system just as much. So if we just want to disable
the tests for now we should do it for all file systems, not just for
the one that found the problem with the test.
next prev parent reply other threads:[~2020-08-31 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 14:53 [PATCH v2] generic: disable dmlogwrites tests on XFS Brian Foster
2020-08-29 6:48 ` Christoph Hellwig
2020-08-31 13:37 ` Brian Foster
2020-08-31 16:02 ` Christoph Hellwig [this message]
2020-09-01 6:25 ` Amir Goldstein
2020-09-01 12:31 ` Brian Foster
2020-09-01 14:04 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831160214.GA6740@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.