Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Hennerich, Michael" <Michael.Hennerich@analog.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	"Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
	William Sung <william.sung@advantech.com.tw>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Campion Kang <Campion.Kang@advantech.com.tw>
Subject: Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes
Date: Wed, 2 Sep 2020 14:23:33 +0100	[thread overview]
Message-ID: <20200902142333.00005b71@Huawei.com> (raw)
In-Reply-To: <CAHp75VcXLyw40JaU42jQ3fSL7mtHPv++xqcka-oTKUbsW4erpg@mail.gmail.com>

On Wed, 2 Sep 2020 12:28:02 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Sep 2, 2020 at 12:12 PM Hennerich, Michael
> <Michael.Hennerich@analog.com> wrote:
> > > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Sent: Mittwoch, 2. September 2020 10:52
> > > On Wed, Sep 2, 2020 at 11:09 AM Hennerich, Michael
> > > <Michael.Hennerich@analog.com> wrote:  
> 
> ...
> 
> > > I see. Can we consider this email as the official answer from AD that this ID is
> > > being allocated for this certain component?  
> >
> > To my knowledge only PNP/ACPI vendor IDs need to be registered with the UEFI
> > ACPI working group.  
> 
> Correct.
> 
> >  AD part numbers are unique. The ID chosen uses the
> > part number prefixed with the PNP Vendor ID. ADxxxx->ADSxxxx
> > Please consider this as allocated.  
> 
> Thank you for confirming this!
> 

Great to clear this particular one up.

One side note on this for anyone who might find this email thread.
If we do have an ACPI ID that doesn't use an official
PNP or ACPI ID, but there are boards shipping with it, then we can't
drop the ID.   We can however add a note to the driver making the
point that it is not an official ID and so we may remove it if
all known boards that used it are now considered obsolete.
Even better to list a product it does occur in so we avoid
having the conversation again!

A lot of these got through my reviews due to lack of knowledge of how
ACPI IDs worked until a few years ago.  Still like all ABI we are
stuck with it until we can remove it without anyone noticing :(

Jonathan