From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vkoul@kernel.org, broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 14/18] ALSA: atmel: ac97: clarify operator precedence
Date: Wed, 2 Sep 2020 16:21:29 -0500 [thread overview]
Message-ID: <20200902212133.30964-15-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200902212133.30964-1-pierre-louis.bossart@linux.intel.com>
Fix cppcheck warnings:
sound/atmel/ac97c.c:478:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
casr & AC97C_CSR_OVRUN ? " OVRUN" : "",
^
sound/atmel/ac97c.c:479:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
casr & AC97C_CSR_RXRDY ? " RXRDY" : "",
^
sound/atmel/ac97c.c:480:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
casr & AC97C_CSR_UNRUN ? " UNRUN" : "",
^
sound/atmel/ac97c.c:481:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
casr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
^
sound/atmel/ac97c.c:482:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
casr & AC97C_CSR_TXRDY ? " TXRDY" : "",
^
sound/atmel/ac97c.c:524:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
cosr & AC97C_CSR_OVRUN ? " OVRUN" : "",
^
sound/atmel/ac97c.c:525:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
cosr & AC97C_CSR_RXRDY ? " RXRDY" : "",
^
sound/atmel/ac97c.c:526:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
cosr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
^
sound/atmel/ac97c.c:527:30: style: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
cosr & AC97C_CSR_TXRDY ? " TXRDY" : "",
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/atmel/ac97c.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 1006458f7f85..66ecbd4d034e 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -475,12 +475,12 @@ static irqreturn_t atmel_ac97c_interrupt(int irq, void *dev)
struct snd_pcm_runtime *runtime;
int offset, next_period, block_size;
dev_dbg(&chip->pdev->dev, "channel A event%s%s%s%s%s%s\n",
- casr & AC97C_CSR_OVRUN ? " OVRUN" : "",
- casr & AC97C_CSR_RXRDY ? " RXRDY" : "",
- casr & AC97C_CSR_UNRUN ? " UNRUN" : "",
- casr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
- casr & AC97C_CSR_TXRDY ? " TXRDY" : "",
- !casr ? " NONE" : "");
+ (casr & AC97C_CSR_OVRUN) ? " OVRUN" : "",
+ (casr & AC97C_CSR_RXRDY) ? " RXRDY" : "",
+ (casr & AC97C_CSR_UNRUN) ? " UNRUN" : "",
+ (casr & AC97C_CSR_TXEMPTY) ? " TXEMPTY" : "",
+ (casr & AC97C_CSR_TXRDY) ? " TXRDY" : "",
+ !casr ? " NONE" : "");
if ((casr & camr) & AC97C_CSR_ENDTX) {
runtime = chip->playback_substream->runtime;
block_size = frames_to_bytes(runtime, runtime->period_size);
@@ -521,11 +521,11 @@ static irqreturn_t atmel_ac97c_interrupt(int irq, void *dev)
if (sr & AC97C_SR_COEVT) {
dev_info(&chip->pdev->dev, "codec channel event%s%s%s%s%s\n",
- cosr & AC97C_CSR_OVRUN ? " OVRUN" : "",
- cosr & AC97C_CSR_RXRDY ? " RXRDY" : "",
- cosr & AC97C_CSR_TXEMPTY ? " TXEMPTY" : "",
- cosr & AC97C_CSR_TXRDY ? " TXRDY" : "",
- !cosr ? " NONE" : "");
+ (cosr & AC97C_CSR_OVRUN) ? " OVRUN" : "",
+ (cosr & AC97C_CSR_RXRDY) ? " RXRDY" : "",
+ (cosr & AC97C_CSR_TXEMPTY) ? " TXEMPTY" : "",
+ (cosr & AC97C_CSR_TXRDY) ? " TXRDY" : "",
+ !cosr ? " NONE" : "");
retval = IRQ_HANDLED;
}
--
2.25.1
next prev parent reply other threads:[~2020-09-02 21:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 21:21 [PATCH 00/18] ALSA: cleanups for sparse/cppcheck warnings Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 01/18] ALSA: core: pcm: simplify locking for timers Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 02/18] ALSA: core: memalloc: fix fallthrough position Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 03/18] ALSA: core: pcm_memory: dereference pointer after NULL checks Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 04/18] ALSA: core: timer: remove redundant assignment Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 05/18] ALSA: core: timer: clarify operator precedence Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 06/18] ALSA: compress_offload: dereference after checking for NULL pointer Pierre-Louis Bossart
2020-09-03 4:47 ` Vinod Koul
2020-09-02 21:21 ` [PATCH 07/18] ALSA: compress_offload: remove redundant initialization Pierre-Louis Bossart
2020-09-03 4:47 ` Vinod Koul
2020-09-02 21:21 ` [PATCH 08/18] ALSA: core: init: use DECLARE_COMPLETION_ONSTACK() macro Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 09/18] ALSA: aoa: i2sbus: " Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 10/18] ALSA: hda: auto_parser: remove shadowed variable declaration Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 11/18] ALSA: hda: (cosmetic) align function parameters Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 12/18] ALSA: usb: scarless_gen2: fix endianness issue Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 13/18] ALSA: ac97: (cosmetic) align argument names Pierre-Louis Bossart
2020-09-02 21:21 ` Pierre-Louis Bossart [this message]
2020-09-02 21:21 ` [PATCH 15/18] ALSA: rawmidi: (cosmetic) align function parameters Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 16/18] ALSA: vx: vx_core: clarify operator precedence Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 17/18] ALSA: vx: vx_pcm: remove redundant assignment Pierre-Louis Bossart
2020-09-02 21:21 ` [PATCH 18/18] " Pierre-Louis Bossart
2020-09-03 7:59 ` [PATCH 00/18] ALSA: cleanups for sparse/cppcheck warnings Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902212133.30964-15-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.