From: Matthew Wilcox <willy@infradead.org>
To: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Jeff Layton <jlayton@kernel.org>,
"J. Bruce Fields" <bfields@fieldses.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS
Date: Mon, 7 Sep 2020 00:07:05 +0100 [thread overview]
Message-ID: <20200906230705.GA27537@casper.infradead.org> (raw)
In-Reply-To: <20200906223949.62771-1-kw@linux.com>
On Sun, Sep 06, 2020 at 10:39:49PM +0000, Krzysztof Wilczyński wrote:
> The O_NDELAY flag occurs twice in the VALID_OPEN_FLAGS definition, this
> change removes the duplicate. There is no change to the functionality.
>
> Note, that the flags O_NONBLOCK and O_NDELAY are not duplicates, as
> values of these flags are platform dependent, and on platforms like
> Sparc O_NONBLOCK and O_NDELAY are not the same.
>
> This has been done that way to maintain the ABI compatibility with
> Solaris since the Sparc port was first introduced.
>
> This change resolves the following Coccinelle warning:
>
> include/linux/fcntl.h:11:13-21: duplicated argument to & or |
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2020-09-06 23:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 22:39 [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS Krzysztof Wilczyński
2020-09-06 23:07 ` Matthew Wilcox [this message]
2020-09-07 16:46 ` Jens Axboe
2020-09-16 19:35 ` Krzysztof Wilczyński
2020-09-16 23:28 ` Al Viro
2020-09-18 16:16 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200906230705.GA27537@casper.infradead.org \
--to=willy@infradead.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=kw@linux.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.