From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Mani, Rajmohan" <rajmohan.mani@intel.com>,
linux-acpi@vger.kernel.org,
Utkarsh Patel <utkarsh.h.patel@intel.com>
Subject: Re: [PATCH 2/2] usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes
Date: Mon, 7 Sep 2020 16:10:58 +0200 [thread overview]
Message-ID: <20200907141058.GA3720524@kroah.com> (raw)
In-Reply-To: <20200907135740.19941-3-heikki.krogerus@linux.intel.com>
On Mon, Sep 07, 2020 at 04:57:40PM +0300, Heikki Krogerus wrote:
> From: Utkarsh Patel <utkarsh.h.patel@intel.com>
>
> According to the PMC Type C Subsystem (TCSS) Mux programming guide rev
> 0.7, bits 4 and 5 are reserved in Alternate modes.
> SBU Orientation and HSL Orientation needs to be configured only during
> initial cable detection in USB connect flow based on device property of
> "sbu-orientation" and "hsl-orientation".
> Configuring these reserved bits in the Alternate modes may result in delay
> in display link training or some unexpected behaviour.
> So do not configure them while issuing Alternate Mode requests.
>
> Fixes: ff4a30d5e243 ("usb: typec: mux: intel_pmc_mux: Support for static SBU/HSL orientation")
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Shouldn't this also need a cc:stable?
And why not cc: the linux-usb list on these patches?
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-07 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 13:57 [PATCH 0/2] Fixes for the Intel PMC mux driver Heikki Krogerus
2020-09-07 13:57 ` [PATCH 1/2] usb: typec: intel_pmc_mux: Do not configure Altmode HPD High Heikki Krogerus
2020-09-07 13:57 ` [PATCH 2/2] usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes Heikki Krogerus
2020-09-07 14:10 ` Greg Kroah-Hartman [this message]
2020-09-07 14:15 ` Heikki Krogerus
2020-09-07 14:12 ` [PATCH 0/2] Fixes for the Intel PMC mux driver Heikki Krogerus
2020-09-07 14:21 [RESEND PATCH 0/2] " Heikki Krogerus
2020-09-07 14:21 ` [PATCH 2/2] usb: typec: intel_pmc_mux: Do not configure SBU and HSL Orientation in Alternate modes Heikki Krogerus
2020-09-07 14:53 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907141058.GA3720524@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.