From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, kieran.bingham@ideasonboard.com,
niklas.soderlund@ragnatech.se, jacopo@jmondi.org
Subject: Re: [PATCH 1/3] v4l2-fwnode: Make number of data lanes a character
Date: Tue, 8 Sep 2020 15:40:26 +0300 [thread overview]
Message-ID: <20200908124026.GH6047@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200908085121.864-2-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Tue, Sep 08, 2020 at 11:51:19AM +0300, Sakari Ailus wrote:
> The maximum is currently four (4). No short is needed.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> include/media/v4l2-fwnode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/media/v4l2-fwnode.h b/include/media/v4l2-fwnode.h
> index c47b70636e42..81e7eb123294 100644
> --- a/include/media/v4l2-fwnode.h
> +++ b/include/media/v4l2-fwnode.h
> @@ -40,7 +40,7 @@ struct v4l2_fwnode_bus_mipi_csi2 {
> unsigned int flags;
> unsigned char data_lanes[V4L2_FWNODE_CSI2_MAX_DATA_LANES];
> unsigned char clock_lane;
> - unsigned short num_data_lanes;
> + unsigned char num_data_lanes;
> bool lane_polarities[1 + V4L2_FWNODE_CSI2_MAX_DATA_LANES];
That's a 4 bytes gain, it's useful.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-09-08 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:51 [PATCH 0/3] Improve V4L2 fwnode framework usability and documentation Sakari Ailus
2020-09-08 8:51 ` [PATCH 1/3] v4l2-fwnode: Make number of data lanes a character Sakari Ailus
2020-09-08 12:40 ` Laurent Pinchart [this message]
2020-09-08 8:51 ` [PATCH 2/3] v4l2-fwnode: Make bus configuration a struct Sakari Ailus
2020-09-08 12:47 ` Laurent Pinchart
2020-09-08 8:51 ` [PATCH 3/3] v4l2-fwnode: Document changes usage patterns of v4l2_fwnode_endpoint_parse Sakari Ailus
2020-09-08 8:55 ` Sakari Ailus
2020-09-08 12:51 ` Laurent Pinchart
2020-09-08 13:33 ` Sakari Ailus
2020-09-14 14:55 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908124026.GH6047@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.