Re: [PATCH v6 1/3] powerpc: Refactor kexec functions to move arch independent code to IMA

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v6 1/3] powerpc: Refactor kexec functions to move arch independent code to IMA
Date: Wed, 09 Sep 2020 13:48:34 +0800	[thread overview]
Message-ID: <202009091337.CBU38341%lkp@intel.com> (raw)
In-Reply-To: <20200908230856.9799-2-nramas@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 3104 bytes --]

Hi Lakshmi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on powerpc/next integrity/next-integrity v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lakshmi-Ramasubramanian/Carry-forward-IMA-measurement-log-on-kexec-on-ARM64/20200909-122123
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-randconfig-s001-20200909 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-191-g10164920-dirty
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   security/integrity/ima/ima_fdt.c: In function 'ima_remove_kexec_buffer':
>> security/integrity/ima/ima_fdt.c:77:8: error: implicit declaration of function 'delete_fdt_mem_rsv' [-Werror=implicit-function-declaration]
      77 |  ret = delete_fdt_mem_rsv(fdt, addr, size);
         |        ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/2d9181b7dc2aac775c161ce9641ee1d0d091f36b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lakshmi-Ramasubramanian/Carry-forward-IMA-measurement-log-on-kexec-on-ARM64/20200909-122123
git checkout 2d9181b7dc2aac775c161ce9641ee1d0d091f36b
vim +/delete_fdt_mem_rsv +77 security/integrity/ima/ima_fdt.c

    46	
    47	/**
    48	 * ima_remove_kexec_buffer - remove the IMA buffer property and
    49	 *			     reservation from @fdt
    50	 *
    51	 * @fdt: Flattened Device Tree to update
    52	 * @chosen_node: Offset to the chosen node in the device tree
    53	 *
    54	 * The IMA measurement buffer is of no use to a subsequent kernel,
    55	 * so we always remove it from the device tree.
    56	 */
    57	void ima_remove_kexec_buffer(void *fdt, int chosen_node)
    58	{
    59		int ret, len;
    60		unsigned long addr;
    61		size_t size;
    62		const void *prop;
    63	
    64		prop = fdt_getprop(fdt, chosen_node, FDT_PROP_IMA_KEXEC_BUFFER, &len);
    65		if (!prop) {
    66			pr_err("Unable to find the ima kexec buffer node\n");
    67			return;
    68		}
    69	
    70		ret = do_get_kexec_buffer(prop, len, &addr, &size);
    71		fdt_delprop(fdt, chosen_node, FDT_PROP_IMA_KEXEC_BUFFER);
    72		if (ret) {
    73			pr_err("Unable to delete the ima kexec buffer node\n");
    74			return;
    75		}
    76	
  > 77		ret = delete_fdt_mem_rsv(fdt, addr, size);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27564 bytes --]