From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/4] mkfs: set required parts of the realtime geometry before computing log geometry
Date: Wed, 9 Sep 2020 12:12:14 -0700 [thread overview]
Message-ID: <20200909191214.GN7955@magnolia> (raw)
In-Reply-To: <20200908144040.GE6039@infradead.org>
On Tue, Sep 08, 2020 at 03:40:40PM +0100, Christoph Hellwig wrote:
> On Mon, Sep 07, 2020 at 10:51:55AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The minimum log size depends on the transaction reservation sizes, which
> > in turn depend on the realtime device geometry. Therefore, we need to
> > set up some of the rt geometry before we can compute the real minimum
> > log size.
> >
> > This fixes a problem where mkfs, given a small data device and a
> > realtime volume, formats a filesystem with a log that is too small to
> > pass the mount time log size checks.
>
> Do we have a test for that?
Yeah, I'm going to do a huge fstests patchbomb after I come back from
vacation next week. Sorry I didn't quite get to it in time.
--D
> Othewise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-09 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 17:51 [PATCH 0/4] xfsprogs: various fixes for 5.9 Darrick J. Wong
2020-09-07 17:51 ` [PATCH 1/4] man: install all manpages that redirect to another manpage Darrick J. Wong
2020-09-08 14:34 ` Christoph Hellwig
2020-09-09 19:11 ` Darrick J. Wong
2020-09-11 2:57 ` Allison Collins
2020-09-07 17:51 ` [PATCH 2/4] mkfs.xfs: tweak wording of external log device size complaint Darrick J. Wong
2020-09-08 14:36 ` Christoph Hellwig
2020-09-11 2:57 ` Allison Collins
2020-09-07 17:51 ` [PATCH 3/4] mkfs: fix reflink/rmap logic w.r.t. realtime devices and crc=0 support Darrick J. Wong
2020-09-08 14:38 ` Christoph Hellwig
2020-09-11 2:57 ` Allison Collins
2020-09-07 17:51 ` [PATCH 4/4] mkfs: set required parts of the realtime geometry before computing log geometry Darrick J. Wong
2020-09-08 14:40 ` Christoph Hellwig
2020-09-09 19:12 ` Darrick J. Wong [this message]
2020-09-11 2:58 ` Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909191214.GN7955@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.