From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 0/4] sample hooks: become hash agnostic
Date: Fri, 18 Sep 2020 21:35:07 +0000 [thread overview]
Message-ID: <20200918213507.GD67496@camp.crustytoothpaste.net> (raw)
In-Reply-To: <cover.1600427894.git.liu.denton@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On 2020-09-18 at 11:19:01, Denton Liu wrote:
> There are currently two hooks that have hardcoded 40 zeros as the null
> OID and, thus, are not hash-agnostic. Rewrite these to use the newly
> introduced `git rev-parse --null-oid` so that they become hash-agnostic.
I've looked over this series and I fully agree that the scripts should
be hash agnostic. I offered an alternative which you may find simpler
and more appealing (or not), but with the constraint that if we add
--null-oid, it should accept an argument, I have no comments beyond what
other folks have added.
--
brian m. carlson: Houston, Texas, US
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2020-09-18 21:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 11:19 [PATCH 0/4] sample hooks: become hash agnostic Denton Liu
2020-09-18 11:19 ` [PATCH 1/4] hooks--pre-push.sample: prefer $() for command substitution Denton Liu
2020-09-18 16:57 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 2/4] builtin/rev-parse: learn --null-oid Denton Liu
2020-09-18 14:11 ` Taylor Blau
2020-09-18 14:16 ` Taylor Blau
2020-09-18 18:16 ` Junio C Hamano
2020-09-18 18:21 ` Taylor Blau
2020-09-18 21:26 ` brian m. carlson
2020-09-20 4:25 ` Chris Torek
2020-09-20 18:58 ` brian m. carlson
2020-09-20 15:35 ` Taylor Blau
2020-09-20 16:03 ` Andreas Schwab
2020-09-18 11:19 ` [PATCH 3/4] hooks--pre-push.sample: use hash-agnostic null OID Denton Liu
2020-09-18 17:06 ` Eric Sunshine
2020-09-18 11:19 ` [PATCH 4/4] hooks--update.sample: " Denton Liu
2020-09-18 17:08 ` Eric Sunshine
2020-09-18 21:35 ` brian m. carlson [this message]
2020-09-23 9:38 ` [PATCH v2 0/3] sample hooks: become hash agnostic Denton Liu
2020-09-23 9:38 ` [PATCH v2 1/3] hooks--pre-push.sample: modernize script Denton Liu
2020-09-23 9:38 ` [PATCH v2 2/3] hooks--pre-push.sample: use hash-agnostic zero OID Denton Liu
2020-09-23 9:38 ` [PATCH v2 3/3] hooks--update.sample: " Denton Liu
2020-09-23 16:34 ` [PATCH v2 0/3] sample hooks: become hash agnostic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918213507.GD67496@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.