Re: [PATCH v5 bpf-next 2/6] bpf: move to generic BTF show support, apply it to seq files/strings

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 bpf-next 2/6] bpf: move to generic BTF show support, apply it to seq files/strings
Date: Sat, 19 Sep 2020 02:44:46 +0800	[thread overview]
Message-ID: <202009190221.bSFD7V5E%lkp@intel.com> (raw)
In-Reply-To: <1600436075-2961-3-git-send-email-alan.maguire@oracle.com>

[-- Attachment #1: Type: text/plain, Size: 2440 bytes --]

Hi Alan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Alan-Maguire/bpf-add-helpers-to-support-BTF-based-kernel-data-display/20200918-213932
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: mips-randconfig-r003-20200918 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0ff28fa6a75617d61b1aeea77463d6a1684c3c89)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/bpf/btf.c:5310:6: warning: no previous prototype for function 'btf_type_show' [-Wmissing-prototypes]
   void btf_type_show(const struct btf *btf, u32 type_id, void *obj,
        ^
   kernel/bpf/btf.c:5310:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void btf_type_show(const struct btf *btf, u32 type_id, void *obj,
   ^
   static 
   1 warning generated.

# https://github.com/0day-ci/linux/commit/a85186d405b24251bfd7179ae1949f3458e9702d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Alan-Maguire/bpf-add-helpers-to-support-BTF-based-kernel-data-display/20200918-213932
git checkout a85186d405b24251bfd7179ae1949f3458e9702d
vim +/btf_type_show +5310 kernel/bpf/btf.c

  5309	
> 5310	void btf_type_show(const struct btf *btf, u32 type_id, void *obj,
  5311			   struct btf_show *show)
  5312	{
  5313		const struct btf_type *t = btf_type_by_id(btf, type_id);
  5314	
  5315		show->btf = btf;
  5316		memset(&show->state, 0, sizeof(show->state));
  5317		memset(&show->obj, 0, sizeof(show->obj));
  5318	
  5319		btf_type_ops(t)->show(btf, t, type_id, obj, 0, show);
  5320	}
  5321	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35531 bytes --]