From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 21/21] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver
Date: Sat, 19 Sep 2020 13:53:24 +0800 [thread overview]
Message-ID: <202009191315.4uO8yJz5%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4574 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200915145958.19993-22-tzimmermann@suse.de>
References: <20200915145958.19993-22-tzimmermann@suse.de>
TO: Thomas Zimmermann <tzimmermann@suse.de>
TO: alexander.deucher(a)amd.com
TO: christian.koenig(a)amd.com
TO: airlied(a)linux.ie
TO: daniel(a)ffwll.ch
TO: linux(a)armlinux.org.uk
TO: maarten.lankhorst(a)linux.intel.com
TO: mripard(a)kernel.org
TO: l.stach(a)pengutronix.de
TO: christian.gmeiner(a)gmail.com
TO: inki.dae(a)samsung.com
Hi Thomas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200915]
[cannot apply to drm-intel/for-linux-next arm/drm-armada-devel linus/master arm/drm-armada-fixes anholt/for-next v5.9-rc5 v5.9-rc4 v5.9-rc3 v5.9-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200915-230157
base: 6b02addb1d1748d21dd1261e46029b264be4e5a0
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: i386-randconfig-m021-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/drm_prime.c:389 export_and_register_object() error: uninitialized symbol 'dmabuf'.
Old smatch warnings:
drivers/gpu/drm/drm_prime.c:359 drm_gem_prime_fd_to_handle() warn: inconsistent returns 'dev->object_name_lock'.
# https://github.com/0day-ci/linux/commit/84300c9d089d60d5dc528a7bd6e2870090201f0e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thomas-Zimmermann/Convert-all-remaining-drivers-to-GEM-object-functions/20200915-230157
git checkout 84300c9d089d60d5dc528a7bd6e2870090201f0e
vim +/dmabuf +389 drivers/gpu/drm/drm_prime.c
89177644a7b630 Aaron Plattner 2013-01-15 374
319c933c71f3db Daniel Vetter 2013-08-15 375 static struct dma_buf *export_and_register_object(struct drm_device *dev,
319c933c71f3db Daniel Vetter 2013-08-15 376 struct drm_gem_object *obj,
319c933c71f3db Daniel Vetter 2013-08-15 377 uint32_t flags)
319c933c71f3db Daniel Vetter 2013-08-15 378 {
319c933c71f3db Daniel Vetter 2013-08-15 379 struct dma_buf *dmabuf;
319c933c71f3db Daniel Vetter 2013-08-15 380
319c933c71f3db Daniel Vetter 2013-08-15 381 /* prevent races with concurrent gem_close. */
319c933c71f3db Daniel Vetter 2013-08-15 382 if (obj->handle_count == 0) {
319c933c71f3db Daniel Vetter 2013-08-15 383 dmabuf = ERR_PTR(-ENOENT);
319c933c71f3db Daniel Vetter 2013-08-15 384 return dmabuf;
319c933c71f3db Daniel Vetter 2013-08-15 385 }
319c933c71f3db Daniel Vetter 2013-08-15 386
b39b5394fabc79 Noralf Trønnes 2018-11-10 387 if (obj->funcs && obj->funcs->export)
b39b5394fabc79 Noralf Trønnes 2018-11-10 388 dmabuf = obj->funcs->export(obj, flags);
319c933c71f3db Daniel Vetter 2013-08-15 @389 if (IS_ERR(dmabuf)) {
319c933c71f3db Daniel Vetter 2013-08-15 390 /* normally the created dma-buf takes ownership of the ref,
319c933c71f3db Daniel Vetter 2013-08-15 391 * but if that fails then drop the ref
319c933c71f3db Daniel Vetter 2013-08-15 392 */
319c933c71f3db Daniel Vetter 2013-08-15 393 return dmabuf;
319c933c71f3db Daniel Vetter 2013-08-15 394 }
319c933c71f3db Daniel Vetter 2013-08-15 395
319c933c71f3db Daniel Vetter 2013-08-15 396 /*
319c933c71f3db Daniel Vetter 2013-08-15 397 * Note that callers do not need to clean up the export cache
319c933c71f3db Daniel Vetter 2013-08-15 398 * since the check for obj->handle_count guarantees that someone
319c933c71f3db Daniel Vetter 2013-08-15 399 * will clean it up.
319c933c71f3db Daniel Vetter 2013-08-15 400 */
319c933c71f3db Daniel Vetter 2013-08-15 401 obj->dma_buf = dmabuf;
319c933c71f3db Daniel Vetter 2013-08-15 402 get_dma_buf(obj->dma_buf);
319c933c71f3db Daniel Vetter 2013-08-15 403
319c933c71f3db Daniel Vetter 2013-08-15 404 return dmabuf;
319c933c71f3db Daniel Vetter 2013-08-15 405 }
319c933c71f3db Daniel Vetter 2013-08-15 406
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34183 bytes --]
next reply other threads:[~2020-09-19 5:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 5:53 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-15 14:59 [PATCH v2 00/21] Convert all remaining drivers to GEM object functions Thomas Zimmermann
2020-09-15 14:59 ` [PATCH v2 21/21] drm: Remove obsolete GEM and PRIME callbacks from struct drm_driver Thomas Zimmermann
2020-09-15 14:59 ` Thomas Zimmermann
2020-09-15 14:59 ` Thomas Zimmermann
2020-09-15 14:59 ` Thomas Zimmermann
2020-09-15 14:59 ` Thomas Zimmermann
2020-09-15 14:59 ` Thomas Zimmermann
2020-09-16 8:01 ` kernel test robot
2020-09-16 10:16 ` kernel test robot
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 12:12 ` Daniel Vetter
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-16 17:55 ` Thomas Zimmermann
2020-09-21 8:11 ` Dan Carpenter
2020-09-21 8:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202009191315.4uO8yJz5%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.