From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
alsa-devel@alsa-project.org, filip.kaczmarski@intel.com,
harshapriya.n@intel.com, gregkh@linuxfoundation.org,
ppapierkowski@habana.ai, marcin.barlik@intel.com,
zwisler@google.com, pierre-louis.bossart@linux.intel.com,
lgirdwood@gmail.com, filip.proborszcz@intel.com,
broonie@kernel.org, michal.wasko@intel.com, tiwai@suse.com,
krzysztof.hejmowski@intel.com, cujomalainey@chromium.org,
vamshi.krishna.gopal@intel.com
Subject: Re: [PATCH v7 03/14] ASoC: Intel: catpt: Add IPC message handlers
Date: Mon, 21 Sep 2020 17:20:12 +0300 [thread overview]
Message-ID: <20200921142012.GY3956970@smile.fi.intel.com> (raw)
In-Reply-To: <2c073526-fc9d-832b-48d4-f955e3b99e24@linux.intel.com>
On Mon, Sep 21, 2020 at 03:58:33PM +0200, Amadeusz Sławiński wrote:
> On 9/21/2020 2:59 PM, Andy Shevchenko wrote:
> > > +struct catpt_set_volume_input {
> > > + u32 channel;
> > > + u32 target_volume;
> > > + u64 curve_duration;
> > > + enum catpt_audio_curve_type curve_type __aligned(4);
> > > +} __packed;
> > How this __packed changes anything? In general __packed doesn't make sense for
> > in-kernel data structures. Otherwise you have to use proper (POD) types for
> > data. Ditto for all similar cases.
>
> All of __packed use in code is done on structures used to communicate with
> FW, which is binary interface, so it is not kernel only structure, as it is
> also FW one. While we can expect compiler to do the right thing, I consider
> it is better to be explicit about what kind of data we are handling, so
> there aren't any surprises.
Size of enum is compiler defined. It may not be used in the ABIs.
__uXX vs. uXX I dunno.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-21 14:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 11:54 [PATCH v7 00/14] ASoC: Intel: Catpt - Lynx and Wildcat point Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 01/14] ASoC: Intel: Add catpt base members Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 02/14] ASoC: Intel: catpt: Implement IPC protocol Cezary Rojewski
2020-09-21 13:00 ` Andy Shevchenko
2020-09-21 17:57 ` Rojewski, Cezary
2020-09-21 11:54 ` [PATCH v7 03/14] ASoC: Intel: catpt: Add IPC message handlers Cezary Rojewski
2020-09-21 12:59 ` Andy Shevchenko
2020-09-21 13:58 ` Amadeusz Sławiński
2020-09-21 14:20 ` Andy Shevchenko [this message]
2020-09-21 14:23 ` Andy Shevchenko
2020-09-21 18:14 ` Rojewski, Cezary
2020-09-21 18:13 ` Rojewski, Cezary
2020-09-21 18:41 ` Andy Shevchenko
2020-09-21 20:48 ` Rojewski, Cezary
2020-09-22 9:04 ` Andy Shevchenko
2020-09-22 11:04 ` Rojewski, Cezary
2020-09-22 11:29 ` Andy Shevchenko
2020-09-22 11:30 ` Andy Shevchenko
2020-09-22 11:56 ` Rojewski, Cezary
2020-09-21 11:54 ` [PATCH v7 04/14] ASoC: Intel: catpt: Define DSP operations Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 05/14] ASoC: Intel: catpt: Firmware loading and context restore Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 06/14] ASoC: Intel: catpt: PCM operations Cezary Rojewski
2020-09-21 14:08 ` Andy Shevchenko
2020-09-21 18:50 ` Rojewski, Cezary
2020-09-21 11:54 ` [PATCH v7 07/14] ASoC: Intel: catpt: Device driver lifecycle Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 08/14] ASoC: Intel: catpt: Event tracing Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 09/14] ASoC: Intel: catpt: Simple sysfs attributes Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 10/14] ASoC: Intel: haswell: Remove haswell-solution specific code Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 11/14] ASoC: Intel: broadwell: " Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 12/14] ASoC: Intel: bdw-5650: " Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 13/14] ASoC: Intel: bdw-5677: " Cezary Rojewski
2020-09-21 11:54 ` [PATCH v7 14/14] ASoC: Intel: Select catpt and deprecate haswell Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921142012.GY3956970@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=filip.kaczmarski@intel.com \
--cc=filip.proborszcz@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=harshapriya.n@intel.com \
--cc=krzysztof.hejmowski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=marcin.barlik@intel.com \
--cc=michal.wasko@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ppapierkowski@habana.ai \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.