From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: paulmck <paulmck@kernel.org>,
Michael Jeanson <mjeanson@efficios.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Yafang Shao <laoar.shao@gmail.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Michel Lespinasse <walken@google.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Davidlohr Bueso <dbueso@suse.de>, linux-mm <linux-mm@kvack.org>,
Ingo Molnar <mingo@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header
Date: Fri, 25 Sep 2020 12:26:47 -0400 [thread overview]
Message-ID: <20200925122647.230decde@oasis.local.home> (raw)
In-Reply-To: <965650354.69699.1601047806662.JavaMail.zimbra@efficios.com>
On Fri, 25 Sep 2020 11:30:06 -0400 (EDT)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> > Anyway, I don't see any issues with the current patch set as is
> > (besides the documentation fix, which I already updated locally). And
> > will add this to my queue for linux-next.
>
> The only thing I would change in the documentation is to word this as
> "here is a trampoline trick which can be used to work-around rare cases
> of tracepoint header circular dependency issues" rather than "always use
> this when instrumenting a header".
>
I rather not have tracepoints in headers. Period!
It's not just about circular dependencies, it also bloats the code.
-- Steve
next prev parent reply other threads:[~2020-09-25 16:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 17:09 [PATCH 0/2] tracing/mm: Add tracepoint_enabled() helper function for headers Steven Rostedt
2020-09-24 17:09 ` [PATCH 1/2] tracepoints: Add helper to test if tracepoint is enabled in a header Steven Rostedt
2020-09-24 17:42 ` Mathieu Desnoyers
2020-09-24 17:42 ` Mathieu Desnoyers
2020-09-24 18:19 ` Axel Rasmussen
2020-09-24 18:19 ` Axel Rasmussen
2020-09-24 18:27 ` Mathieu Desnoyers
2020-09-24 18:27 ` Mathieu Desnoyers
2020-09-24 18:30 ` Steven Rostedt
2020-09-24 19:08 ` Mathieu Desnoyers
2020-09-24 19:08 ` Mathieu Desnoyers
2020-09-24 19:35 ` Steven Rostedt
2020-09-24 19:40 ` Steven Rostedt
2020-09-24 20:25 ` Mathieu Desnoyers
2020-09-24 20:25 ` Mathieu Desnoyers
2020-09-24 20:05 ` Mathieu Desnoyers
2020-09-24 20:05 ` Mathieu Desnoyers
2020-09-24 20:13 ` Steven Rostedt
2020-09-24 20:27 ` Mathieu Desnoyers
2020-09-24 20:27 ` Mathieu Desnoyers
2020-09-24 20:33 ` Steven Rostedt
2020-09-25 14:41 ` Mathieu Desnoyers
2020-09-25 14:41 ` Mathieu Desnoyers
2020-09-25 15:14 ` Steven Rostedt
2020-09-25 15:30 ` Mathieu Desnoyers
2020-09-25 15:30 ` Mathieu Desnoyers
2020-09-25 16:26 ` Steven Rostedt [this message]
2020-09-25 17:05 ` Mathieu Desnoyers
2020-09-25 17:05 ` Mathieu Desnoyers
2020-09-24 20:04 ` Axel Rasmussen
2020-09-24 20:04 ` Axel Rasmussen
2020-09-24 17:09 ` [PATCH 2/2] mm/page_ref: Convert the open coded tracepoint enabled to the new helper Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925122647.230decde@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dbueso@suse.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=mjeanson@efficios.com \
--cc=paulmck@kernel.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.