From: "hch@infradead.org" <hch@infradead.org>
To: "Derrick, Jonathan" <jonathan.derrick@intel.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"helgaas@kernel.org" <helgaas@kernel.org>,
"andrzej.jakowski@linux.intel.com"
<andrzej.jakowski@linux.intel.com>,
"Fugate, David" <david.fugate@intel.com>
Subject: Re: [PATCH 2/3] PCI: Introduce a minimizing assignment algorithm
Date: Tue, 29 Sep 2020 18:48:20 +0100 [thread overview]
Message-ID: <20200929174820.GA1113@infradead.org> (raw)
In-Reply-To: <5062649eee1c179245c435a415da8dad87ef6325.camel@intel.com>
On Mon, Sep 28, 2020 at 01:34:50PM +0000, Derrick, Jonathan wrote:
> Well this fix in particular may not be needed once the dynamic hotplug
> resource resizing set is in and build on that. But frankly the generic
> resource assignment code itself is very difficult to work within and
> has been discussed at several LPC over the years. I don't see a problem
> with another algorithm which could be relied upon by other host bridge
> controller drivers if they want it.
>
> I also spent a good deal of time trying to get the minimizing algorithm
> into pci_assign_unassigned_root_bus_resources, where the only instance
> of pci=realloc detection takes place (who knew there were so many
> originating different paths for resource assignment?). I couldn't make
> headway there so started fresh. Maybe someone talented could refactor
> mine into it and save a few instruction bytes.
If the maintainers think there might be other use cases we could
also just make it conditional and let VMD select it. I'm just a little
worried but all kinds of cruft slipping into core code to work around
the various problems vmd creates.
next prev parent reply other threads:[~2020-09-29 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 1:06 [PATCH 0/3] PCI: Minimizing resource assignment algorithm Jon Derrick
2020-09-28 1:06 ` [PATCH 1/3] PCI: Create helper to release/restore bridge resources Jon Derrick
2020-09-28 1:06 ` [PATCH 2/3] PCI: Introduce a minimizing assignment algorithm Jon Derrick
2020-09-28 7:17 ` Christoph Hellwig
2020-09-28 13:34 ` Derrick, Jonathan
2020-09-29 17:48 ` hch [this message]
2020-09-28 1:06 ` [PATCH 3/3] PCI: vmd: Wire up VMD for fallback resource assignment Jon Derrick
2020-09-28 7:16 ` [PATCH 0/3] PCI: Minimizing resource assignment algorithm Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929174820.GA1113@infradead.org \
--to=hch@infradead.org \
--cc=andrzej.jakowski@linux.intel.com \
--cc=david.fugate@intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.