From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: gregkh@linuxfoundation.org
Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org,
linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 16/19] bus: mhi: core: Allow shared IRQ for event rings
Date: Tue, 29 Sep 2020 23:22:15 +0530 [thread overview]
Message-ID: <20200929175218.8178-17-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20200929175218.8178-1-manivannan.sadhasivam@linaro.org>
From: Loic Poulain <loic.poulain@linaro.org>
There is no requirement for using a dedicated IRQ per event ring.
Some systems does not support multiple MSI vectors (e.g. intel
without CONFIG_IRQ_REMAP), In that case the MHI controller can
configure all the event rings to use the same interrupt (as fallback).
Allow this by removing the nr_irqs = ev_ring test and add extra check
in the irq_setup function.
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/core/init.c | 7 +++++++
drivers/bus/mhi/core/pm.c | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index a33665b7ee54..103d51f35e28 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -162,6 +162,13 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl)
if (mhi_event->offload_ev)
continue;
+ if (mhi_event->irq >= mhi_cntrl->nr_irqs) {
+ dev_err(dev, "irq %d not available for event ring\n",
+ mhi_event->irq);
+ ret = -EINVAL;
+ goto error_request;
+ }
+
ret = request_irq(mhi_cntrl->irq[mhi_event->irq],
mhi_irq_handler,
IRQF_SHARED | IRQF_NO_SUSPEND,
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index ce4d969818b4..3de7b1639ec6 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -918,7 +918,7 @@ int mhi_async_power_up(struct mhi_controller *mhi_cntrl)
dev_info(dev, "Requested to power ON\n");
- if (mhi_cntrl->nr_irqs < mhi_cntrl->total_ev_rings)
+ if (mhi_cntrl->nr_irqs < 1)
return -EINVAL;
/* Supply default wake routines if not provided by controller driver */
--
2.17.1
next prev parent reply other threads:[~2020-09-29 17:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 17:51 [PATCH v3 00/19] MHI changes for v5.10 Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 01/19] bus: mhi: fix doubled words and struct image_info kernel-doc Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 02/19] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 03/19] bus: mhi: core: Abort suspends due to outgoing pending packets Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 04/19] bus: mhi: core: Use helper API to trigger a non-blocking host resume Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 05/19] bus: mhi: core: Trigger host resume if suspended during mhi_device_get() Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 06/19] bus: mhi: core: Use generic name field for an MHI device Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 07/19] bus: mhi: core: Introduce helper function to check device state Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 08/19] bus: mhi: core: Introduce counters to track MHI device state transitions Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 09/19] bus: mhi: core: Read and save device hardware information from BHI Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 10/19] bus: mhi: core: Introduce APIs to allocate and free the MHI controller Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 11/19] bus: mhi: core: Add const qualifier to MHI config information Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 12/19] bus: mhi: Remove include of rwlock_types.h Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 13/19] bus: mhi: Fix entries based on Kconfig coding style Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 14/19] bus: mhi: core: Introduce debugfs entries for MHI Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 15/19] bus: mhi: core: Introduce sysfs " Manivannan Sadhasivam
2020-09-29 17:52 ` Manivannan Sadhasivam [this message]
2020-09-29 17:52 ` [PATCH v3 17/19] bus: mhi: Remove unused nr_irqs_req variable Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 18/19] bus: mhi: core: Fix the building of MHI module Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 19/19] bus: mhi: debugfs: Print channel context read-pointer Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929175218.8178-17-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.