From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Pratyush Anand <pratyush.anand@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH 1/2] PCI: dwc: armada-8k driver needs OF support
Date: Thu, 1 Oct 2020 12:17:30 +0100 [thread overview]
Message-ID: <20201001111729.GA6420@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20201001074244.349443-1-thomas.petazzoni@bootlin.com>
On Thu, Oct 01, 2020 at 09:42:43AM +0200, Thomas Petazzoni wrote:
> Fixes the following build warning when CONFIG_OF is disabled:
>
> drivers/pci/controller/dwc/pcie-armada8k.c:344:34: warning: ‘armada8k_pcie_of_match’ defined but not used [-Wunused-const-variable=]
> 344 | static const struct of_device_id armada8k_pcie_of_match[] = {
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Reported-by: Bjorn Helgaas <helgaas@kernel.org>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> drivers/pci/controller/dwc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Merged both patches into pci/dwc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 044a3761c44f..96994b715f26 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -176,7 +176,7 @@ config PCIE_QCOM
>
> config PCIE_ARMADA_8K
> bool "Marvell Armada-8K PCIe controller"
> - depends on ARCH_MVEBU || COMPILE_TEST
> + depends on OF && (ARCH_MVEBU || COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> help
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-10-01 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 7:42 [PATCH 1/2] PCI: dwc: armada-8k driver needs OF support Thomas Petazzoni
2020-10-01 7:42 ` [PATCH 2/2] PCI: dwc: spear13xx driver needs OF Thomas Petazzoni
2020-10-01 11:17 ` Lorenzo Pieralisi [this message]
2020-10-05 21:58 ` [PATCH 1/2] PCI: dwc: armada-8k driver needs OF support Bjorn Helgaas
2021-12-02 11:06 ` [PATCH] PCI: Improve compile-test coverage Fan Fei
2021-12-02 17:31 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001111729.GA6420@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pratyush.anand@gmail.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.