From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 00/15] nfsd_dispatch() clean up
Date: Fri, 2 Oct 2020 13:39:08 -0400 [thread overview]
Message-ID: <20201002173908.GA31151@fieldses.org> (raw)
In-Reply-To: <160159301676.79253.16488984581431975601.stgit@klimt.1015granger.net>
I'm seeing a pynfs4.0 GATT9 regression. That's a test that attempts a
compound with 90 GETATTR ops each a request for all mandatory
attributes. The test expects OK or RESOURCE but looks like its getting
a corrupted response? (I haven't looked at the wire traffic yet.) I
think it's one of the final patches changing how errors are returned.
--b.
On Thu, Oct 01, 2020 at 06:58:46PM -0400, Chuck Lever wrote:
> Hi Bruce-
>
> Here's the latest version of the nfsd_dispatch clean up series,
> building on the "non-controversial" patches I posted last week.
>
> The purpose of this series is three-fold:
>
> o Prepare to add NFS procedure tracepoints
> o Prepare to eventually deprecate NFSv2
> o Minor optimizations of the dispatcher hot path
>
>
> Changes since v2:
> - Fixed crasher caused by invoking NFSv2 ROOT or WRITECACHE
> - Hoisted encoding of NFS status code into XDR Reply encoders
> - Numerous bug fixes, clean ups, and patch re-ordering
>
> Changes since v1:
> - Pulled in latest version of rq_lease_breaker cleanup
> - Added patches to make NFSv2 error encoding similar to NFSv3
> - Clarified nfsd_dispatch's new documenting comment
> - Renamed a variable
>
> ---
>
> Chuck Lever (14):
> NFSD: Add missing NFSv2 .pc_func methods
> lockd: Replace PROC() macro with open code
> NFSACL: Replace PROC() macro with open code
> NFSD: Encoder and decoder functions are always present
> NFSD: Clean up switch statement in nfsd_dispatch()
> NFSD: Clean up stale comments in nfsd_dispatch()
> NFSD: Clean up nfsd_dispatch() variables
> NFSD: Refactor nfsd_dispatch() error paths
> NFSD: Remove vestigial typedefs
> NFSD: Fix .pc_release method for NFSv2
> NFSD: Call NFSv2 encoders on error returns
> NFSD: Remove the RETURN_STATUS() macro
> NFSD: Map nfserr_wrongsec outside of nfsd_dispatch
> NFSD: Hoist status code encoding into XDR encoder functions
>
> J. Bruce Fields (1):
> nfsd: rq_lease_breaker cleanup
>
>
> fs/lockd/svc4proc.c | 248 ++++++++++++++++++++++++-------
> fs/lockd/svcproc.c | 250 ++++++++++++++++++++++++-------
> fs/nfsd/export.c | 2 +-
> fs/nfsd/nfs2acl.c | 160 +++++++++++++-------
> fs/nfsd/nfs3acl.c | 88 ++++++-----
> fs/nfsd/nfs3proc.c | 238 +++++++++++++++---------------
> fs/nfsd/nfs3xdr.c | 25 +++-
> fs/nfsd/nfs4proc.c | 6 +-
> fs/nfsd/nfs4xdr.c | 11 +-
> fs/nfsd/nfsproc.c | 283 ++++++++++++++++++++----------------
> fs/nfsd/nfssvc.c | 121 ++++++++-------
> fs/nfsd/nfsxdr.c | 52 ++++++-
> fs/nfsd/xdr.h | 16 +-
> fs/nfsd/xdr3.h | 1 +
> fs/nfsd/xdr4.h | 1 +
> include/uapi/linux/nfsacl.h | 2 +
> 16 files changed, 984 insertions(+), 520 deletions(-)
>
> --
> Chuck Lever
next prev parent reply other threads:[~2020-10-02 17:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 22:58 [PATCH v3 00/15] nfsd_dispatch() clean up Chuck Lever
2020-10-01 22:58 ` [PATCH v3 01/15] nfsd: rq_lease_breaker cleanup Chuck Lever
2020-10-01 22:58 ` [PATCH v3 02/15] NFSD: Add missing NFSv2 .pc_func methods Chuck Lever
2020-10-01 22:59 ` [PATCH v3 03/15] lockd: Replace PROC() macro with open code Chuck Lever
2020-10-01 22:59 ` [PATCH v3 04/15] NFSACL: " Chuck Lever
2020-10-01 22:59 ` [PATCH v3 05/15] NFSD: Encoder and decoder functions are always present Chuck Lever
2020-10-01 22:59 ` [PATCH v3 06/15] NFSD: Clean up switch statement in nfsd_dispatch() Chuck Lever
2020-10-01 22:59 ` [PATCH v3 07/15] NFSD: Clean up stale comments " Chuck Lever
2020-10-01 22:59 ` [PATCH v3 08/15] NFSD: Clean up nfsd_dispatch() variables Chuck Lever
2020-10-01 22:59 ` [PATCH v3 09/15] NFSD: Refactor nfsd_dispatch() error paths Chuck Lever
2020-10-01 22:59 ` [PATCH v3 10/15] NFSD: Remove vestigial typedefs Chuck Lever
2020-10-01 22:59 ` [PATCH v3 11/15] NFSD: Fix .pc_release method for NFSv2 Chuck Lever
2020-10-01 22:59 ` [PATCH v3 12/15] NFSD: Call NFSv2 encoders on error returns Chuck Lever
2020-10-01 22:59 ` [PATCH v3 13/15] NFSD: Remove the RETURN_STATUS() macro Chuck Lever
2020-10-01 23:00 ` [PATCH v3 14/15] NFSD: Map nfserr_wrongsec outside of nfsd_dispatch Chuck Lever
2020-10-01 23:00 ` [PATCH v3 15/15] NFSD: Hoist status code encoding into XDR encoder functions Chuck Lever
2020-10-02 17:39 ` J. Bruce Fields [this message]
2020-10-02 17:42 ` [PATCH v3 00/15] nfsd_dispatch() clean up J. Bruce Fields
2020-10-02 17:44 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002173908.GA31151@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.