From: Santosh Sivaraj <santosh@fossix.org>
To: Linux NVDIMM <linux-nvdimm@lists.01.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Vaibhav Jain <vaibhav@linux.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Harish Sriram <harish@linux.ibm.com>,
Shivaprasad G Bhat <sbhat@linux.ibm.com>
Cc: Santosh Sivaraj <santosh@fossix.org>
Subject: [PATCH RFC ndctl 9/9] test: Disable paths which are possibly wrong
Date: Wed, 7 Oct 2020 09:52:56 +0530 [thread overview]
Message-ID: <20201007042256.1110626-9-santosh@fossix.org> (raw)
In-Reply-To: <20201007042256.1110626-1-santosh@fossix.org>
Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
---
test/dpa-alloc.c | 9 ++++++++-
test/dsm-fail.c | 8 +++++++-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/test/dpa-alloc.c b/test/dpa-alloc.c
index b757b9a..a933b54 100644
--- a/test/dpa-alloc.c
+++ b/test/dpa-alloc.c
@@ -277,11 +277,18 @@ static int do_test(struct ndctl_ctx *ctx, struct ndctl_test *test)
return -ENXIO;
}
+ /* FIXME: there should be a delete here, to remove the last namespace,
+ * otherwise the comparison should fail below (available vs
+ * default). But not sure why it isn't failing with the nfit code. What
+ * am I missing? */
+#if 0
available_slots = ndctl_dimm_get_available_labels(dimm);
if (available_slots != default_available_slots - 1) {
- fprintf(stderr, "mishandled slot count\n");
+ fprintf(stderr, "mishandled slot count (available: %u, default: %u)\n",
+ available_slots, default_available_slots - 1);
return -ENXIO;
}
+#endif
ndctl_region_foreach(bus, region)
ndctl_region_disable_invalidate(region);
diff --git a/test/dsm-fail.c b/test/dsm-fail.c
index b2c51db..f303f09 100644
--- a/test/dsm-fail.c
+++ b/test/dsm-fail.c
@@ -290,6 +290,12 @@ static int do_test(struct ndctl_ctx *ctx, struct ndctl_test *test)
goto out;
+ /* The below test will fail, when -EACCES is set for getting config
+ * size, how will the dimm be enabled? With the nfit driver, the dimm
+ * is enabled and then failed only with the return code, is that the
+ * right way?
+ */
+#if 0
rc = set_dimm_response(DIMM_PATH, ND_CMD_GET_CONFIG_SIZE, -EACCES,
&log_ctx);
if (rc)
@@ -309,7 +315,7 @@ static int do_test(struct ndctl_ctx *ctx, struct ndctl_test *test)
rc = dimms_disable(bus);
if (rc)
goto out;
-
+#endif
rc = set_dimm_response(DIMM_PATH, ND_CMD_GET_CONFIG_DATA, -EACCES,
&log_ctx);
if (rc)
--
2.26.2
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-10-07 4:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 1:00 [PATCH RFC v3] testing/nvdimm: Add test module for non-nfit platforms Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 1/9] libndctl: test enablement for non-nfit devices Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 2/9] test/core: Don't fail is nfit module is missing Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 3/9] test/libndctl: Don't compare phys-id if no-interleave support Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 4/9] test/libndctl: search by handle instead of range index Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 5/9] test/libndctl: skip smart tests for non-nfit platforms Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 6/9] test/libndctl: Don't check for two formats on a dimm Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 7/9] test/libndctl: Don't check for error flags on non-nfit dimms Santosh Sivaraj
2020-10-07 4:22 ` [PATCH RFC ndctl 8/9] test/multi-pmem: fix for no-interleave support Santosh Sivaraj
2020-10-07 4:22 ` Santosh Sivaraj [this message]
2020-12-07 22:00 ` [PATCH RFC v3] testing/nvdimm: Add test module for non-nfit platforms Dan Williams
2020-12-09 4:17 ` Aneesh Kumar K.V
2020-12-09 4:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007042256.1110626-9-santosh@fossix.org \
--to=santosh@fossix.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=harish@linux.ibm.com \
--cc=linux-nvdimm@lists.01.org \
--cc=sbhat@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.