From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com, ukernel@gmail.com, pdonnell@redhat.com
Subject: [PATCH v4 1/5] ceph: don't WARN when removing caps due to blocklisting
Date: Wed, 7 Oct 2020 08:16:56 -0400 [thread overview]
Message-ID: <20201007121700.10489-2-jlayton@kernel.org> (raw)
In-Reply-To: <20201007121700.10489-1-jlayton@kernel.org>
We expect to remove dirty caps when the client is blocklisted. Don't
throw a warning in that case.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/ceph/caps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
index c7e69547628e..2ee3f316afcf 100644
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1149,7 +1149,7 @@ void __ceph_remove_cap(struct ceph_cap *cap, bool queue_release)
/* remove from inode's cap rbtree, and clear auth cap */
rb_erase(&cap->ci_node, &ci->i_caps);
if (ci->i_auth_cap == cap) {
- WARN_ON_ONCE(!list_empty(&ci->i_dirty_item));
+ WARN_ON_ONCE(!list_empty(&ci->i_dirty_item) && !mdsc->fsc->blocklisted);
ci->i_auth_cap = NULL;
}
--
2.26.2
next prev parent reply other threads:[~2020-10-07 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 12:16 [PATCH v4 0/5] ceph: fix spurious recover_session=clean errors Jeff Layton
2020-10-07 12:16 ` Jeff Layton [this message]
2020-10-07 12:16 ` [PATCH v4 2/5] ceph: make fsc->mount_state an int Jeff Layton
2020-10-07 12:16 ` [PATCH v4 3/5] ceph: add new RECOVER mount_state when recovering session Jeff Layton
2020-10-07 12:16 ` [PATCH v4 4/5] ceph: remove timeout on allowing reconnect after blocklisting Jeff Layton
2020-10-07 12:17 ` [PATCH v4 5/5] ceph: queue MDS requests to REJECTED sessions when CLEANRECOVER is set Jeff Layton
2020-10-20 7:03 ` [PATCH v4 0/5] ceph: fix spurious recover_session=clean errors Xiubo Li
2020-10-21 13:51 ` Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007121700.10489-2-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=pdonnell@redhat.com \
--cc=ukernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.