Re: [PATCH 08/29] dt-bindings:iio:pressure:hoperf,hp03 yaml conversion

From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	Marek Vasut <marex@denx.de>
Subject: Re: [PATCH 08/29] dt-bindings:iio:pressure:hoperf,hp03 yaml conversion
Date: Mon, 12 Oct 2020 15:31:18 +0100	[thread overview]
Message-ID: <20201012143118.000040f5@Huawei.com> (raw)
In-Reply-To: <CAL_JsqKT7G-E7Ao7AbRwm_J_MRRRqcChpn5xkJZrftTjJLUZtQ@mail.gmail.com>

On Mon, 12 Oct 2020 08:06:46 -0500
Rob Herring <robh+dt@kernel.org> wrote:

> On Sun, Oct 11, 2020 at 12:10 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > One quirk in the txt file was that the xclr gpio was specified as
> > gpio-xclr rather than gpios-xclr. I've fixed that in the  
> 
> xclr-gpios?, not gpios?-xclr

I clearly have a very short memory when writing patch descriptions.
Indeed, xclr-gpios is what this should say. 

> 
> > yaml version.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Marek Vasut <marex@denx.de>
> > ---
> >  .../bindings/iio/pressure/hoperf,hp03.yaml    | 47 +++++++++++++++++++
> >  .../devicetree/bindings/iio/pressure/hp03.txt | 17 -------
> >  2 files changed, 47 insertions(+), 17 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/hoperf,hp03.yaml b/Documentation/devicetree/bindings/iio/pressure/hoperf,hp03.yaml
> > new file mode 100644
> > index 000000000000..69a3759e23db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/pressure/hoperf,hp03.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/pressure/hoperf,hp03.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: HopeRF HP03 digital pressure/temperature sensors
> > +
> > +maintainers:
> > +  - Marek Vasut <marex@denx.de>
> > +
> > +description: |
> > +  Digital pressure and temperature sensor with an I2C interface.
> > +
> > +properties:
> > +  compatible:
> > +    const: hoperf,hp03
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  xclr-gpios:
> > +    description:
> > +      The XCLR pin is a reset of the ADC in the chip, it must be pulled
> > +      HI before the conversion and readout of the value from the ADC
> > +      registers and pulled LO afterward.
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pressure@77 {
> > +            compatible = "hoperf,hp03";
> > +            reg = <0x77>;
> > +            xclr-gpios = <&portc 0 0x0>;
> > +        };
> > +    };
> > +...
> > diff --git a/Documentation/devicetree/bindings/iio/pressure/hp03.txt b/Documentation/devicetree/bindings/iio/pressure/hp03.txt
> > deleted file mode 100644
> > index 831dbee7a5c3..000000000000
> > --- a/Documentation/devicetree/bindings/iio/pressure/hp03.txt
> > +++ /dev/null
> > @@ -1,17 +0,0 @@
> > -HopeRF HP03 digital pressure/temperature sensors
> > -
> > -Required properties:
> > -- compatible: must be "hoperf,hp03"
> > -- xclr-gpio: must be device tree identifier of the XCLR pin.
> > -             The XCLR pin is a reset of the ADC in the chip,
> > -             it must be pulled HI before the conversion and
> > -             readout of the value from the ADC registers and
> > -             pulled LO afterward.
> > -
> > -Example:
> > -
> > -hp03@77 {
> > -       compatible = "hoperf,hp03";
> > -       reg = <0x77>;
> > -       xclr-gpio = <&portc 0 0x0>;
> > -};
> > --
> > 2.28.0
> >  