From: trix@redhat.com
To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
davem@davemloft.net, akpm@linux-foundation.org,
willy@infradead.org, alex.shi@linux.alibaba.com
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH] fs: ocfs2 remove unneeded break
Date: Mon, 19 Oct 2020 10:52:16 -0700 [thread overview]
Message-ID: <20201019175216.2329-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a goto
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/ocfs2/cluster/tcp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index 79a231719460..3bd8119bed5e 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/tcp.c
@@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
msglog(hdr, "bad magic\n");
ret = -EINVAL;
goto out;
- break;
}
/* find a handler for it */
--
2.18.1
WARNING: multiple messages have this Message-ID (diff)
From: trix at redhat.com <trix@redhat.com>
To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
davem@davemloft.net, akpm@linux-foundation.org,
willy@infradead.org, alex.shi@linux.alibaba.com
Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [Ocfs2-devel] [PATCH] fs: ocfs2 remove unneeded break
Date: Mon, 19 Oct 2020 10:52:16 -0700 [thread overview]
Message-ID: <20201019175216.2329-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a goto
Signed-off-by: Tom Rix <trix@redhat.com>
---
fs/ocfs2/cluster/tcp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
index 79a231719460..3bd8119bed5e 100644
--- a/fs/ocfs2/cluster/tcp.c
+++ b/fs/ocfs2/cluster/tcp.c
@@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
msglog(hdr, "bad magic\n");
ret = -EINVAL;
goto out;
- break;
}
/* find a handler for it */
--
2.18.1
next reply other threads:[~2020-10-19 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 17:52 trix [this message]
2020-10-19 17:52 ` [Ocfs2-devel] [PATCH] fs: ocfs2 remove unneeded break trix at redhat.com
2020-10-20 1:20 ` Joseph Qi
2020-10-20 1:20 ` [Ocfs2-devel] " Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019175216.2329-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.