From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joseph Jang <josephjang@google.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
jonglin@google.com, woodylin@google.com, markcheng@google.com
Subject: Re: [PATCH] power: suspend: Replace dpm_watchdog by sleep timer
Date: Tue, 20 Oct 2020 13:08:10 +0200 [thread overview]
Message-ID: <20201020110810.GA194512@kroah.com> (raw)
In-Reply-To: <20201020095611.1763815-1-josephjang@google.com>
On Tue, Oct 20, 2020 at 05:56:11PM +0800, Joseph Jang wrote:
> Since dpm_watchdog just cover device power management,
> we proposed sleep timer to cover not only device power management
> issues, but also core power management hand issue.
>
> Add sleep timer and timeout handler to prevent device stuck during suspend/
> resume process. The timeout handler will dump disk sleep task at first
> round timeout and trigger kernel panic at second round timeout.
> The default timer for each round is defined in
> CONFIG_PM_SLEEP_TIMER_TIMEOUT.
>
> Signed-off-by: Joseph Jang <josephjang@google.com>
> ---
> drivers/base/power/main.c | 69 ---------------------------
> include/linux/console.h | 1 +
> kernel/power/Kconfig | 27 ++++++-----
> kernel/power/suspend.c | 19 ++++++++
> kernel/power/suspend_timer.h | 90 ++++++++++++++++++++++++++++++++++++
> kernel/printk/printk.c | 5 ++
> 6 files changed, 128 insertions(+), 83 deletions(-)
> create mode 100644 kernel/power/suspend_timer.h
Is this different from your previous patches?
If so, you need to properly version them, and put below the --- line
what changed. Otherwise it is impossible to review.
Please fix up.
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-20 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 9:56 [PATCH] power: suspend: Replace dpm_watchdog by sleep timer Joseph Jang
2020-10-20 11:08 ` Greg Kroah-Hartman [this message]
[not found] ` <CAPaOXETgmHATQMM55C+2BKTQDyEnXYjknhWY7KB1jqKYynE-+g@mail.gmail.com>
2020-10-20 11:42 ` Greg Kroah-Hartman
2020-10-20 11:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020110810.GA194512@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jonglin@google.com \
--cc=josephjang@google.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markcheng@google.com \
--cc=pavel@ucw.cz \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=woodylin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.