From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>, "John Snow" <jsnow@redhat.com>
Subject: [PATCH 5/5] gitlab: add python linters to CI
Date: Tue, 27 Oct 2020 18:38:15 -0400 [thread overview]
Message-ID: <20201027223815.159802-6-jsnow@redhat.com> (raw)
In-Reply-To: <20201027223815.159802-1-jsnow@redhat.com>
Add python3.6 to the fedora container image: we need it to run the
linters against that explicit version to make sure we don't break our
minimum version promise. Add pipenv, too.
Signed-off-by: John Snow <jsnow@redhat.com>
---
.gitlab-ci.yml | 10 ++++++++++
tests/docker/dockerfiles/fedora.docker | 2 ++
2 files changed, 12 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 5d6773efd291..1a32e8b9ba83 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -413,6 +413,16 @@ check-patch:
GIT_DEPTH: 1000
allow_failure: true
+
+check-python:
+ stage: build
+ image: $CI_REGISTRY_IMAGE/qemu/fedora:latest
+ script:
+ - cd python
+ - make venv-check
+ variables:
+ GIT_DEPTH: 1000
+
check-dco:
stage: build
image: $CI_REGISTRY_IMAGE/qemu/centos8:latest
diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
index 0b5053f2d090..e065fcda8ff2 100644
--- a/tests/docker/dockerfiles/fedora.docker
+++ b/tests/docker/dockerfiles/fedora.docker
@@ -81,6 +81,7 @@ ENV PACKAGES \
numactl-devel \
perl \
perl-Test-Harness \
+ pipenv \
pixman-devel \
python3 \
python3-PyYAML \
@@ -90,6 +91,7 @@ ENV PACKAGES \
python3-pip \
python3-sphinx \
python3-virtualenv \
+ python3.6 \
rdma-core-devel \
SDL2-devel \
snappy-devel \
--
2.26.2
prev parent reply other threads:[~2020-10-27 22:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 22:38 [PATCH 0/5] python: add linters to gitlab CI John Snow
2020-10-27 22:38 ` [PATCH 1/5] python: add pytest and tests John Snow
2020-10-28 6:19 ` Thomas Huth
2020-10-28 13:23 ` John Snow
2020-10-28 14:09 ` Philippe Mathieu-Daudé
2020-10-28 14:54 ` Thomas Huth
2020-10-28 18:38 ` John Snow
2020-10-27 22:38 ` [PATCH 2/5] python: add excluded dirs to flake8 config John Snow
2020-10-28 8:50 ` Philippe Mathieu-Daudé
2020-10-28 13:42 ` John Snow
2020-10-27 22:38 ` [PATCH 3/5] python: add Makefile for some common tasks John Snow
2020-10-27 22:38 ` [PATCH 4/5] python: add .gitignore John Snow
2020-10-28 8:13 ` Thomas Huth
2020-10-28 9:16 ` Markus Armbruster
2020-10-28 9:22 ` Daniel P. Berrangé
2020-10-28 13:39 ` John Snow
2020-10-28 13:41 ` Daniel P. Berrangé
2020-10-28 13:26 ` John Snow
2020-10-28 18:33 ` John Snow
2020-10-27 22:38 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027223815.159802-6-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.