From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] powerpc: avoid broken GCC __attribute__((optimize))
Date: Wed, 28 Oct 2020 18:08:16 +0800 [thread overview]
Message-ID: <202010281845.gwfIScGd-lkp@intel.com> (raw)
In-Reply-To: <20201028080433.26799-1-ardb@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 9234 bytes --]
Hi Ard,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linus/master linux/master v5.10-rc1 next-20201028]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ard-Biesheuvel/powerpc-avoid-broken-GCC-__attribute__-optimize/20201028-160558
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-r003-20201028 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 50dfa19cc799ae7cddd39a95dbfce675a12672ad)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://github.com/0day-ci/linux/commit/5ccccdce42ea4f2316ac2bf79d5311dc77a70e6e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ard-Biesheuvel/powerpc-avoid-broken-GCC-__attribute__-optimize/20201028-160558
git checkout 5ccccdce42ea4f2316ac2bf79d5311dc77a70e6e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> arch/powerpc/kernel/paca.c:244:6: error: variable has incomplete type 'void'
void __nostackprotector setup_paca(struct paca_struct *new_paca)
^
>> arch/powerpc/kernel/paca.c:244:24: error: expected ';' after top level declarator
void __nostackprotector setup_paca(struct paca_struct *new_paca)
^
;
>> arch/powerpc/kernel/paca.c:274:2: error: use of undeclared identifier 'paca_nr_cpu_ids'; did you mean 'nr_cpu_ids'?
paca_nr_cpu_ids = nr_cpu_ids;
^~~~~~~~~~~~~~~
nr_cpu_ids
include/linux/cpumask.h:39:21: note: 'nr_cpu_ids' declared here
extern unsigned int nr_cpu_ids;
^
>> arch/powerpc/kernel/paca.c:274:18: error: explicitly assigning value of variable of type 'unsigned int' to itself [-Werror,-Wself-assign]
paca_nr_cpu_ids = nr_cpu_ids;
~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
BUG_ON(cpu >= paca_nr_cpu_ids);
^
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
arch/powerpc/kernel/paca.c:328:2: error: use of undeclared identifier 'paca_nr_cpu_ids'; did you mean 'nr_cpu_ids'?
paca_nr_cpu_ids = nr_cpu_ids;
^~~~~~~~~~~~~~~
nr_cpu_ids
include/linux/cpumask.h:39:21: note: 'nr_cpu_ids' declared here
extern unsigned int nr_cpu_ids;
^
arch/powerpc/kernel/paca.c:328:18: error: explicitly assigning value of variable of type 'unsigned int' to itself [-Werror,-Wself-assign]
paca_nr_cpu_ids = nr_cpu_ids;
~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
9 errors generated.
--
>> arch/powerpc/kernel/paca.c:244:6: error: variable has incomplete type 'void'
void __nostackprotector setup_paca(struct paca_struct *new_paca)
^
>> arch/powerpc/kernel/paca.c:244:24: error: expected ';' after top level declarator
void __nostackprotector setup_paca(struct paca_struct *new_paca)
^
;
>> arch/powerpc/kernel/paca.c:274:2: error: use of undeclared identifier 'paca_nr_cpu_ids'; did you mean 'nr_cpu_ids'?
paca_nr_cpu_ids = nr_cpu_ids;
^~~~~~~~~~~~~~~
nr_cpu_ids
include/linux/cpumask.h:39:21: note: 'nr_cpu_ids' declared here
extern unsigned int nr_cpu_ids;
^
arch/powerpc/kernel/paca.c:274:18: warning: explicitly assigning value of variable of type 'unsigned int' to itself [-Wself-assign]
paca_nr_cpu_ids = nr_cpu_ids;
~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
BUG_ON(cpu >= paca_nr_cpu_ids);
^
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
arch/powerpc/kernel/paca.c:290:16: error: use of undeclared identifier 'paca_nr_cpu_ids'
arch/powerpc/kernel/paca.c:328:2: error: use of undeclared identifier 'paca_nr_cpu_ids'; did you mean 'nr_cpu_ids'?
paca_nr_cpu_ids = nr_cpu_ids;
^~~~~~~~~~~~~~~
nr_cpu_ids
include/linux/cpumask.h:39:21: note: 'nr_cpu_ids' declared here
extern unsigned int nr_cpu_ids;
^
arch/powerpc/kernel/paca.c:328:18: warning: explicitly assigning value of variable of type 'unsigned int' to itself [-Wself-assign]
paca_nr_cpu_ids = nr_cpu_ids;
~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~
2 warnings and 7 errors generated.
vim +/void +244 arch/powerpc/kernel/paca.c
1426d5a3bd07589 Michael Ellerman 2010-01-28 242
fc53b4202e61c7e Matt Evans 2010-07-07 243 /* Put the paca pointer into r13 and SPRG_PACA */
7053f80d96967d8 Michael Ellerman 2020-03-20 @244 void __nostackprotector setup_paca(struct paca_struct *new_paca)
fc53b4202e61c7e Matt Evans 2010-07-07 245 {
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 246 /* Setup r13 */
fc53b4202e61c7e Matt Evans 2010-07-07 247 local_paca = new_paca;
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 248
fc53b4202e61c7e Matt Evans 2010-07-07 249 #ifdef CONFIG_PPC_BOOK3E
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 250 /* On Book3E, initialize the TLB miss exception frames */
fc53b4202e61c7e Matt Evans 2010-07-07 251 mtspr(SPRN_SPRG_TLB_EXFRAME, local_paca->extlb);
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 252 #else
d4a8e98621543d5 Daniel Axtens 2020-03-20 253 /*
d4a8e98621543d5 Daniel Axtens 2020-03-20 254 * In HV mode, we setup both HPACA and PACA to avoid problems
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 255 * if we do a GET_PACA() before the feature fixups have been
d4a8e98621543d5 Daniel Axtens 2020-03-20 256 * applied.
d4a8e98621543d5 Daniel Axtens 2020-03-20 257 *
d4a8e98621543d5 Daniel Axtens 2020-03-20 258 * Normally you should test against CPU_FTR_HVMODE, but CPU features
d4a8e98621543d5 Daniel Axtens 2020-03-20 259 * are not yet set up when we first reach here.
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 260 */
d4a8e98621543d5 Daniel Axtens 2020-03-20 261 if (mfmsr() & MSR_HV)
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 262 mtspr(SPRN_SPRG_HPACA, local_paca);
fc53b4202e61c7e Matt Evans 2010-07-07 263 #endif
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 264 mtspr(SPRN_SPRG_PACA, local_paca);
2dd60d79e020262 Benjamin Herrenschmidt 2011-01-20 265
fc53b4202e61c7e Matt Evans 2010-07-07 266 }
fc53b4202e61c7e Matt Evans 2010-07-07 267
d2e60075a3d4422 Nicholas Piggin 2018-02-14 268 static int __initdata paca_nr_cpu_ids;
d2e60075a3d4422 Nicholas Piggin 2018-02-14 269 static int __initdata paca_ptrs_size;
59f577743d71bf7 Nicholas Piggin 2018-02-14 270 static int __initdata paca_struct_size;
1426d5a3bd07589 Michael Ellerman 2010-01-28 271
59f577743d71bf7 Nicholas Piggin 2018-02-14 272 void __init allocate_paca_ptrs(void)
59f577743d71bf7 Nicholas Piggin 2018-02-14 273 {
59f577743d71bf7 Nicholas Piggin 2018-02-14 @274 paca_nr_cpu_ids = nr_cpu_ids;
59f577743d71bf7 Nicholas Piggin 2018-02-14 275
59f577743d71bf7 Nicholas Piggin 2018-02-14 276 paca_ptrs_size = sizeof(struct paca_struct *) * nr_cpu_ids;
1269f7b83f2cf79 Christophe Leroy 2019-03-11 277 paca_ptrs = memblock_alloc_raw(paca_ptrs_size, SMP_CACHE_BYTES);
1269f7b83f2cf79 Christophe Leroy 2019-03-11 278 if (!paca_ptrs)
1269f7b83f2cf79 Christophe Leroy 2019-03-11 279 panic("Failed to allocate %d bytes for paca pointers\n",
1269f7b83f2cf79 Christophe Leroy 2019-03-11 280 paca_ptrs_size);
1269f7b83f2cf79 Christophe Leroy 2019-03-11 281
59f577743d71bf7 Nicholas Piggin 2018-02-14 282 memset(paca_ptrs, 0x88, paca_ptrs_size);
59f577743d71bf7 Nicholas Piggin 2018-02-14 283 }
1426d5a3bd07589 Michael Ellerman 2010-01-28 284
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30508 bytes --]
next prev parent reply other threads:[~2020-10-28 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 8:04 [PATCH] powerpc: avoid broken GCC __attribute__((optimize)) Ard Biesheuvel
2020-10-28 8:04 ` Ard Biesheuvel
2020-10-28 8:19 ` Test Results: " snowpatch
2020-10-28 8:29 ` [PATCH] " Ard Biesheuvel
2020-10-28 8:29 ` Ard Biesheuvel
2020-10-29 11:35 ` Michael Ellerman
2020-10-29 11:35 ` Michael Ellerman
2020-10-28 10:08 ` kernel test robot [this message]
2020-11-25 11:57 ` Michael Ellerman
2020-11-25 11:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010281845.gwfIScGd-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.