From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Srivatsa, Anusha" <anusha.srivatsa@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Sort EHL/JSL PCI IDs
Date: Fri, 30 Oct 2020 21:55:14 +0200 [thread overview]
Message-ID: <20201030195514.GL6112@intel.com> (raw)
In-Reply-To: <6046b238187a44e0b7c569efc7d0e9b8@intel.com>
On Fri, Oct 30, 2020 at 07:34:01PM +0000, Srivatsa, Anusha wrote:
>
>
> > -----Original Message-----
> > From: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Sent: Friday, October 30, 2020 9:41 AM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>
> > Subject: [PATCH v2] drm/i915: Sort EHL/JSL PCI IDs
> >
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Sort the EHL/JSL PCI IDs numerically. Some order seems better than
> > randomness.
> >
> > v2: Deal with the JSL vs. EHL split
> >
> > Reviewed-by: Anusha Srivatsa <anusha.srivatsa@intel.com> #v1
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > include/drm/i915_pciids.h | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > 3b5ed1e4f3ec..4a0a06f4a81e 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -585,19 +585,19 @@
> > /* EHL */
> > #define INTEL_EHL_IDS(info) \
> > INTEL_VGA_DEVICE(0x4500, info), \
> 0x4500 is actually no longer a valid PCI ID for the platform.
Can you fire off a patch to remove the invalid stuff?
I can hold off on pushing this until those changes are
done, if that's the more convenient approach.
>
> Anusha
> > - INTEL_VGA_DEVICE(0x4571, info), \
> > - INTEL_VGA_DEVICE(0x4551, info), \
> > INTEL_VGA_DEVICE(0x4541, info), \
> > + INTEL_VGA_DEVICE(0x4551, info), \
> > + INTEL_VGA_DEVICE(0x4555, info), \
> > INTEL_VGA_DEVICE(0x4557, info), \
> > - INTEL_VGA_DEVICE(0x4555, info)
> > + INTEL_VGA_DEVICE(0x4571, info)
> >
> > /* JSL */
> > #define INTEL_JSL_IDS(info) \
> > - INTEL_VGA_DEVICE(0x4E71, info), \
> > - INTEL_VGA_DEVICE(0x4E61, info), \
> > - INTEL_VGA_DEVICE(0x4E57, info), \
> > + INTEL_VGA_DEVICE(0x4E51, info), \
> > INTEL_VGA_DEVICE(0x4E55, info), \
> > - INTEL_VGA_DEVICE(0x4E51, info)
> > + INTEL_VGA_DEVICE(0x4E57, info), \
> > + INTEL_VGA_DEVICE(0x4E61, info), \
> > + INTEL_VGA_DEVICE(0x4E71, info)
> >
> > /* TGL */
> > #define INTEL_TGL_12_GT1_IDS(info) \
> > --
> > 2.26.2
>
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-30 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 16:41 [Intel-gfx] [PATCH v2] drm/i915: Sort EHL/JSL PCI IDs Ville Syrjala
2020-10-30 17:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-30 19:34 ` [Intel-gfx] [PATCH v2] " Srivatsa, Anusha
2020-10-30 19:55 ` Ville Syrjälä [this message]
2020-10-30 21:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030195514.GL6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.