From: Matthew Wilcox <willy@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Joe Perches <joe@perches.com>, Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mm: shmem: Convert shmem_enabled_show to use sysfs_emit_at
Date: Mon, 2 Nov 2020 14:08:36 +0000 [thread overview]
Message-ID: <20201102140836.GJ27442@casper.infradead.org> (raw)
In-Reply-To: <20201102133343.GA1011963@kroah.com>
On Mon, Nov 02, 2020 at 02:33:43PM +0100, Greg Kroah-Hartman wrote:
> > Oh, ugh, sysfs_emit() should be able to work on a buffer that isn't
> > page aligned. Greg, how about this?
>
> How can sysfs_emit() be called on a non-page-aligned buffer? It's being
> used on the buffer that was passed to the sysfs call.
>
> And if you are writing multiple values to a single sysfs file output,
> well, not good...
See shmem_enabled_show() in mm/shmem.c (output at
/sys/kernel/mm/transparent_hugepage/shmem_enabled on your machine).
I don't claim it's a good interface, but it exists.
next prev parent reply other threads:[~2020-11-02 14:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 20:12 [PATCH 0/5] mm: Convert sysfs sprintf family to sysfs_emit Joe Perches
2020-11-01 20:12 ` [PATCH 1/5] mm: Use sysfs_emit for struct kobject * uses Joe Perches
2020-11-01 20:12 ` [PATCH 2/5] mm: huge_memory: Convert remaining use of sprintf to sysfs_emit and neatening Joe Perches
2020-11-01 20:12 ` [PATCH 3/5] mm:backing-dev: Use sysfs_emit in macro defining functions Joe Perches
2020-11-01 20:12 ` [PATCH 4/5] mm: shmem: Convert shmem_enabled_show to use sysfs_emit_at Joe Perches
2020-11-01 20:48 ` Matthew Wilcox
2020-11-01 21:04 ` Joe Perches
2020-11-01 21:04 ` Joe Perches
2020-11-01 21:19 ` Matthew Wilcox
2020-11-01 21:43 ` Joe Perches
2020-11-01 21:43 ` Joe Perches
2020-11-01 22:06 ` Matthew Wilcox
2020-11-01 22:08 ` Joe Perches
2020-11-01 22:08 ` Joe Perches
2020-11-01 22:13 ` Joe Perches
2020-11-01 22:13 ` Joe Perches
2020-11-01 22:14 ` Joe Perches
2020-11-01 22:14 ` Joe Perches
2020-11-02 13:33 ` Greg Kroah-Hartman
2020-11-02 14:08 ` Matthew Wilcox [this message]
2020-11-02 14:32 ` Greg Kroah-Hartman
2020-11-02 14:40 ` Matthew Wilcox
2020-11-02 17:01 ` Joe Perches
2020-11-02 17:01 ` Joe Perches
2020-11-01 20:12 ` [PATCH 5/5] mm: slub: Convert sysfs sprintf family to sysfs_emit/sysfs_emit_at Joe Perches
2020-11-13 12:10 ` [mm] b6efe2fcc4: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2020-11-13 12:10 ` [LTP] [mm] b6efe2fcc4: BUG:kernel_NULL_pointer_dereference, address kernel test robot
2020-11-13 16:13 ` [mm] b6efe2fcc4: BUG:kernel_NULL_pointer_dereference,address Joe Perches
2020-11-13 16:13 ` [LTP] [mm] b6efe2fcc4: BUG:kernel_NULL_pointer_dereference, address Joe Perches
2020-11-13 16:13 ` [mm] b6efe2fcc4: BUG:kernel_NULL_pointer_dereference,address Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102140836.GJ27442@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.