From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: ordered-data: rename parameter @len to @nr_sectors
Date: Tue, 3 Nov 2020 20:16:09 +0100 [thread overview]
Message-ID: <20201103191609.GC6756@twin.jikos.cz> (raw)
In-Reply-To: <20201028072432.86907-3-wqu@suse.com>
On Wed, Oct 28, 2020 at 03:24:31PM +0800, Qu Wenruo wrote:
> The parameter is the number of sectors of the range to search.
> While most "len" we used in other locations are in byte size, this can
> lead to confusion.
>
> Rename @len to @nr_sectors to make it more clear and avoid confusion.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> fs/btrfs/ordered-data.c | 9 ++++++---
> fs/btrfs/ordered-data.h | 2 +-
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
> index ebac13389e7e..10c13f8a1603 100644
> --- a/fs/btrfs/ordered-data.c
> +++ b/fs/btrfs/ordered-data.c
> @@ -802,9 +802,11 @@ btrfs_lookup_first_ordered_extent(struct inode *inode, u64 file_offset)
> * search the ordered extents for one corresponding to 'offset' and
> * try to find a checksum. This is used because we allow pages to
> * be reclaimed before their checksum is actually put into the btree
> + *
> + * @nr_sectors: The length of the search range, in sectors.
Please add all parameters
> */
> int btrfs_find_ordered_sum(struct inode *inode, u64 offset, u64 disk_bytenr,
> - u8 *sum, int len)
> + u8 *sum, int nr_sectors)
next prev parent reply other threads:[~2020-11-03 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:24 [PATCH 0/3] btrfs: btrfs_lookup_bio_sums() related fixes Qu Wenruo
2020-10-28 7:24 ` [PATCH 1/3] btrfs: file-item: use nodesize to determine whether we need readhead for btrfs_lookup_bio_sums() Qu Wenruo
2020-10-29 7:25 ` Nikolay Borisov
2020-10-28 7:24 ` [PATCH 2/3] btrfs: ordered-data: rename parameter @len to @nr_sectors Qu Wenruo
2020-10-29 7:32 ` Nikolay Borisov
2020-11-03 19:16 ` David Sterba [this message]
2020-11-03 19:23 ` Amy Parker
2020-11-03 23:36 ` Qu Wenruo
2020-10-28 7:24 ` [PATCH 3/3] btrfs: file-item: refactor btrfs_lookup_bio_sums() to handle out-of-order bvecs Qu Wenruo
2020-11-03 19:46 ` David Sterba
2020-11-03 23:42 ` Qu Wenruo
2020-11-16 16:27 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103191609.GC6756@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.