From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Dan Carpenter <dan.carpenter@oracle.com>,
Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH] ext4: unlock xattr_sem properly in ext4_inline_data_truncate()
Date: Fri, 6 Nov 2020 22:29:30 -0500 [thread overview]
Message-ID: <20201107032930.GB2499342@mit.edu> (raw)
In-Reply-To: <8B6EE337-4C54-42C3-BB2C-5D191143FAC7@dilger.ca>
On Mon, Nov 02, 2020 at 08:15:36PM -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 7:29 PM, Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> >
> > It takes xattr_sem to check inline data again but without unlock it
> > in case not have. So unlock it before return.
> >
> > Fixes: aef1c8513c1f ("ext4: let ext4_truncate handle inline data correctly")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Cc: Tao Ma <boyu.mt@taobao.com>
> > Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2020-11-07 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 2:29 [PATCH] ext4: unlock xattr_sem properly in ext4_inline_data_truncate() Joseph Qi
2020-11-03 3:15 ` Andreas Dilger
2020-11-07 3:29 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107032930.GB2499342@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=boyu.mt@taobao.com \
--cc=dan.carpenter@oracle.com \
--cc=jack@suse.cz \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.