From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] r8169: fix potential skb double free in an error path
Date: Sat, 7 Nov 2020 12:13:15 -0800 [thread overview]
Message-ID: <20201107121315.4d4068bf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <f7e68191-acff-9ded-4263-c016428a8762@gmail.com>
On Thu, 5 Nov 2020 15:28:42 +0100 Heiner Kallweit wrote:
> The caller of rtl8169_tso_csum_v2() frees the skb if false is returned.
> eth_skb_pad() internally frees the skb on error what would result in a
> double free. Therefore use __skb_put_padto() directly and instruct it
> to not free the skb on error.
>
> Fixes: 25e992a4603c ("r8169: rename r8169.c to r8169_main.c")
> Reported-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> The Fixes tag refers to the change from which on the patch applies.
> However it will apply with a little fuzz only on versions up to 5.9.
I think we've been over this, please provide real fixes tags, pointing
to where bugs were introduced. I swapped the tag for:
Fixes: b423e9ae49d7 ("r8169: fix offloaded tx checksum for small packets.")
and applied, thanks.
prev parent reply other threads:[~2020-11-07 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 14:28 [PATCH net] r8169: fix potential skb double free in an error path Heiner Kallweit
2020-11-07 20:13 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107121315.4d4068bf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.