From: Matthew Wilcox <willy@infradead.org>
To: Yang Shi <shy828301@gmail.com>
Cc: mhocko@suse.com, ziy@nvidia.com, songliubraving@fb.com,
mgorman@suse.de, jack@suse.cz, akpm@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing
Date: Tue, 10 Nov 2020 18:16:36 +0000 [thread overview]
Message-ID: <20201110181636.GJ17076@casper.infradead.org> (raw)
In-Reply-To: <20201110181250.264394-4-shy828301@gmail.com>
On Tue, Nov 10, 2020 at 10:12:48AM -0800, Yang Shi wrote:
> @@ -2142,6 +2151,10 @@ int migrate_misplaced_transhuge_page(struct mm_struct *mm,
> int page_lru = page_is_file_lru(page);
> unsigned long start = address & HPAGE_PMD_MASK;
>
> + if (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS) &&
> + is_shared_exec_page(vma, page))
> + goto out;
Why include the IS_ENABLED() check? Once the ~50 patches I have pending
go in, shared executable THPs can exist without this option. And can't
we have executables on tmpfs today without this option too?
next prev parent reply other threads:[~2020-11-10 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 18:12 [v2 PATCH 0/5] mm: misc migrate cleanup and improvement Yang Shi
2020-11-10 18:12 ` [v2 PATCH 1/5] mm: truncate_complete_page is not existed anymore Yang Shi
2020-11-10 18:12 ` [v2 PATCH 2/5] mm: migrate: simplify the logic for handling permanent failure Yang Shi
2020-11-10 18:12 ` [v2 PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing Yang Shi
2020-11-10 18:16 ` Matthew Wilcox [this message]
2020-11-10 18:58 ` Yang Shi
2020-11-10 18:58 ` Yang Shi
2020-11-10 18:12 ` [v2 PATCH 4/5] mm: migrate: clean up migrate_prep{_local} Yang Shi
2020-11-10 18:12 ` [v2 PATCH 5/5] mm: migrate: return -ENOSYS if THP migration is unsupported Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110181636.GJ17076@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.