All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	kent.overstreet@gmail.com
Subject: Re: [PATCH v3 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec
Date: Tue, 10 Nov 2020 18:25:15 +0000	[thread overview]
Message-ID: <20201110182515.GK17076@casper.infradead.org> (raw)
In-Reply-To: <20201110182118.GB28701@lst.de>

On Tue, Nov 10, 2020 at 07:21:18PM +0100, Christoph Hellwig wrote:
> On Tue, Nov 10, 2020 at 03:36:48AM +0000, Matthew Wilcox (Oracle) wrote:
> > Using a pagevec lets us keep the pages and the number of pages together
> > which simplifies a lot of the calling conventions.
> > 
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> 
> I hate the > 80 char lines in a few spots, but otherwise this looks good:

They're all gone by the end of this series.  It's just less churn to
ignore the 80 columns limit for the intermediate patches.

> Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2020-11-10 18:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10  3:36 [PATCH v3 00/18] Refactor generic_file_buffered_read Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 01/18] mm/filemap: Rename generic_file_buffered_read subfunctions Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 02/18] mm/filemap: Remove dynamically allocated array from filemap_read Matthew Wilcox (Oracle)
2020-11-10 18:20   ` Christoph Hellwig
2020-11-10  3:36 ` [PATCH v3 03/18] mm/filemap: Convert filemap_get_pages to take a pagevec Matthew Wilcox (Oracle)
2020-11-10 18:21   ` Christoph Hellwig
2020-11-10 18:25     ` Matthew Wilcox [this message]
2020-11-10  3:36 ` [PATCH v3 04/18] mm/filemap: Use THPs in generic_file_buffered_read Matthew Wilcox (Oracle)
2020-11-17 16:00   ` Zi Yan
2020-11-17 16:07     ` Matthew Wilcox
2020-11-10  3:36 ` [PATCH v3 05/18] mm/filemap: Pass a sleep state to put_and_wait_on_page_locked Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 06/18] mm/filemap: Support readpage splitting a page Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 07/18] mm/filemap: Inline __wait_on_page_locked_async into caller Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 08/18] mm/filemap: Don't call ->readpage if IOCB_WAITQ is set Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 09/18] mm/filemap: Change filemap_read_page calling conventions Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 10/18] mm/filemap: Change filemap_create_page " Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 11/18] mm/filemap: Convert filemap_update_page to return an errno Matthew Wilcox (Oracle)
2020-11-10 18:22   ` Christoph Hellwig
2020-11-10  3:36 ` [PATCH v3 12/18] mm/filemap: Move the iocb checks into filemap_update_page Matthew Wilcox (Oracle)
2020-11-10  3:36 ` [PATCH v3 13/18] mm/filemap: Add filemap_range_uptodate Matthew Wilcox (Oracle)
2020-11-10 18:22   ` Christoph Hellwig
2020-11-10  3:36 ` [PATCH v3 14/18] mm/filemap: Split filemap_readahead out of filemap_get_pages Matthew Wilcox (Oracle)
2020-11-10 18:23   ` Christoph Hellwig
2020-11-10  3:37 ` [PATCH v3 15/18] mm/filemap: Restructure filemap_get_pages Matthew Wilcox (Oracle)
2020-11-10 18:24   ` Christoph Hellwig
2020-11-10  3:37 ` [PATCH v3 16/18] mm/filemap: Don't relock the page after calling readpage Matthew Wilcox (Oracle)
2020-11-10 18:24   ` Christoph Hellwig
2020-11-10  3:37 ` [PATCH v3 17/18] mm/filemap: Rename generic_file_buffered_read to filemap_read Matthew Wilcox (Oracle)
2020-11-10  3:37 ` [PATCH v3 18/18] mm/filemap: Simplify generic_file_read_iter Matthew Wilcox (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201110182515.GK17076@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=hch@lst.de \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.