Re: [PATCH v10 31/41] btrfs: mark block groups to copy for device-replace

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v10 31/41] btrfs: mark block groups to copy for device-replace
Date: Wed, 11 Nov 2020 11:13:44 +0800	[thread overview]
Message-ID: <202011111127.xMzvQY3m-lkp@intel.com> (raw)
In-Reply-To: <b57f5fd21c034e4157295a930913ae2b7db64c5d.1605007037.git.naohiro.aota@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 5521 bytes --]

Hi Naohiro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on xfs-linux/for-next]
[also build test WARNING on v5.10-rc3]
[cannot apply to kdave/for-next block/for-next next-20201110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Naohiro-Aota/btrfs-zoned-block-device-support/20201110-193227
base:   https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/355d6db6997f390f363f08fa9bfbf8b38eb891a2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Naohiro-Aota/btrfs-zoned-block-device-support/20201110-193227
        git checkout 355d6db6997f390f363f08fa9bfbf8b38eb891a2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/btrfs/dev-replace.c: In function 'mark_block_group_to_copy':
>> fs/btrfs/dev-replace.c:452:20: warning: variable 'length' set but not used [-Wunused-but-set-variable]
     452 |  u64 chunk_offset, length;
         |                    ^~~~~~

vim +/length +452 fs/btrfs/dev-replace.c

   440	
   441	static int mark_block_group_to_copy(struct btrfs_fs_info *fs_info,
   442					    struct btrfs_device *src_dev)
   443	{
   444		struct btrfs_path *path;
   445		struct btrfs_key key;
   446		struct btrfs_key found_key;
   447		struct btrfs_root *root = fs_info->dev_root;
   448		struct btrfs_dev_extent *dev_extent = NULL;
   449		struct btrfs_block_group *cache;
   450		struct btrfs_trans_handle *trans;
   451		int ret = 0;
 > 452		u64 chunk_offset, length;
   453	
   454		/* Do not use "to_copy" on non-ZONED for now */
   455		if (!btrfs_is_zoned(fs_info))
   456			return 0;
   457	
   458		mutex_lock(&fs_info->chunk_mutex);
   459	
   460		/* Ensure we don't have pending new block group */
   461		spin_lock(&fs_info->trans_lock);
   462		while (fs_info->running_transaction &&
   463		       !list_empty(&fs_info->running_transaction->dev_update_list)) {
   464			spin_unlock(&fs_info->trans_lock);
   465			mutex_unlock(&fs_info->chunk_mutex);
   466			trans = btrfs_attach_transaction(root);
   467			if (IS_ERR(trans)) {
   468				ret = PTR_ERR(trans);
   469				mutex_lock(&fs_info->chunk_mutex);
   470				if (ret == -ENOENT)
   471					continue;
   472				else
   473					goto unlock;
   474			}
   475	
   476			ret = btrfs_commit_transaction(trans);
   477			mutex_lock(&fs_info->chunk_mutex);
   478			if (ret)
   479				goto unlock;
   480	
   481			spin_lock(&fs_info->trans_lock);
   482		}
   483		spin_unlock(&fs_info->trans_lock);
   484	
   485		path = btrfs_alloc_path();
   486		if (!path) {
   487			ret = -ENOMEM;
   488			goto unlock;
   489		}
   490	
   491		path->reada = READA_FORWARD;
   492		path->search_commit_root = 1;
   493		path->skip_locking = 1;
   494	
   495		key.objectid = src_dev->devid;
   496		key.offset = 0;
   497		key.type = BTRFS_DEV_EXTENT_KEY;
   498	
   499		ret = btrfs_search_slot(NULL, root, &key, path, 0, 0);
   500		if (ret < 0)
   501			goto free_path;
   502		if (ret > 0) {
   503			if (path->slots[0] >=
   504			    btrfs_header_nritems(path->nodes[0])) {
   505				ret = btrfs_next_leaf(root, path);
   506				if (ret < 0)
   507					goto free_path;
   508				if (ret > 0) {
   509					ret = 0;
   510					goto free_path;
   511				}
   512			} else {
   513				ret = 0;
   514			}
   515		}
   516	
   517		while (1) {
   518			struct extent_buffer *l = path->nodes[0];
   519			int slot = path->slots[0];
   520	
   521			btrfs_item_key_to_cpu(l, &found_key, slot);
   522	
   523			if (found_key.objectid != src_dev->devid)
   524				break;
   525	
   526			if (found_key.type != BTRFS_DEV_EXTENT_KEY)
   527				break;
   528	
   529			if (found_key.offset < key.offset)
   530				break;
   531	
   532			dev_extent = btrfs_item_ptr(l, slot, struct btrfs_dev_extent);
   533			length = btrfs_dev_extent_length(l, dev_extent);
   534	
   535			chunk_offset = btrfs_dev_extent_chunk_offset(l, dev_extent);
   536	
   537			cache = btrfs_lookup_block_group(fs_info, chunk_offset);
   538			if (!cache)
   539				goto skip;
   540	
   541			spin_lock(&cache->lock);
   542			cache->to_copy = 1;
   543			spin_unlock(&cache->lock);
   544	
   545			btrfs_put_block_group(cache);
   546	
   547	skip:
   548			ret = btrfs_next_item(root, path);
   549			if (ret != 0) {
   550				if (ret > 0)
   551					ret = 0;
   552				break;
   553			}
   554		}
   555	
   556	free_path:
   557		btrfs_free_path(path);
   558	unlock:
   559		mutex_unlock(&fs_info->chunk_mutex);
   560	
   561		return ret;
   562	}
   563	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 66433 bytes --]