From: Jakub Kicinski <kuba@kernel.org>
To: Vadim Fedorenko <vfedorenko@novek.ru>
Cc: Boris Pismenny <borisp@nvidia.com>,
Aviad Yehezkel <aviadye@nvidia.com>,
netdev@vger.kernel.org
Subject: Re: [net v2] net/tls: fix corrupted data in recvmsg
Date: Mon, 16 Nov 2020 17:12:54 -0800 [thread overview]
Message-ID: <20201116171254.07b99498@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <f88588ce-03c7-74e0-1c43-0213d9133abd@novek.ru>
On Tue, 17 Nov 2020 00:59:54 +0000 Vadim Fedorenko wrote:
> >>> Sorry I wasn't clear enough, should this be:
> >>>
> >>> if (ctx->control != control)
> >>>
> >>> ? Otherwise if we get a control record first and then data record
> >>> the code will collapse them, which isn't correct, right?
> >>>
> >>>> goto recv_end;
> >>>> } else {
> >>>> break;
> >> I think you mean when ctx->control is control record and control is
> >> data record.
> > Yup.
> >
> >> In this case control message will be decrypted without
> >> zero copy and will be stored in skb for the next recvmsg, but will
> >> not be returned together with data message.
> > Could you point me to a line which breaks the loop in that case?
> >
> Sure!
>
> if (!control)
> control = tlm->control;
> else if (control != tlm->control)
> goto recv_end;
>
>
> In that case control != tlm->control
> Variable control is set only once and never changes again.
You're right! Applied, thanks!
prev parent reply other threads:[~2020-11-17 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 4:16 [net v2] net/tls: fix corrupted data in recvmsg Vadim Fedorenko
2020-11-17 0:26 ` Jakub Kicinski
2020-11-17 0:45 ` Vadim Fedorenko
2020-11-17 0:54 ` Jakub Kicinski
2020-11-17 0:59 ` Vadim Fedorenko
2020-11-17 1:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116171254.07b99498@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=aviadye@nvidia.com \
--cc=borisp@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=vfedorenko@novek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.