All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 4/7] io_uring: do not use pointer after free
Date: Tue, 17 Nov 2020 13:15:55 +0100	[thread overview]
Message-ID: <20201117121558.249585-5-kwolf@redhat.com> (raw)
In-Reply-To: <20201117121558.249585-1-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Even though only the pointer value is only printed, it is untidy
and Coverity complains.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20201113154102.1460459-1-pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/io_uring.c b/block/io_uring.c
index 037af09471..00a3ee9fb8 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -425,6 +425,6 @@ LuringState *luring_init(Error **errp)
 void luring_cleanup(LuringState *s)
 {
     io_uring_queue_exit(&s->ring);
-    g_free(s);
     trace_luring_cleanup_state(s);
+    g_free(s);
 }
-- 
2.28.0



  parent reply	other threads:[~2020-11-17 12:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 12:15 [PULL 0/7] Patches for 5.2.0-rc2 Kevin Wolf
2020-11-17 12:15 ` [PULL 1/7] char-stdio: Fix QMP default for 'signal' Kevin Wolf
2020-11-17 12:15 ` [PULL 2/7] iotests: Replace deprecated ConfigParser.readfp() Kevin Wolf
2020-11-17 12:15 ` [PULL 3/7] file-posix: allow -EBUSY errors during write zeros on raw block devices Kevin Wolf
2020-11-17 12:15 ` Kevin Wolf [this message]
2020-11-17 12:15 ` [PULL 5/7] quorum: Require WRITE perm with rewrite-corrupted Kevin Wolf
2020-11-17 12:15 ` [PULL 6/7] iotests/081: Filter image format after testdir Kevin Wolf
2020-11-17 12:15 ` [PULL 7/7] iotests/081: Test rewrite-corrupted without WRITE Kevin Wolf
2020-11-17 16:40 ` [PULL 0/7] Patches for 5.2.0-rc2 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117121558.249585-5-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.