From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Zhang Qilong <zhangqilong3@huawei.com>,
han.xu@nxp.com, miquel.raynal@bootlin.com, vigneshr@ti.com
Cc: richard@nod.at, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: gpmi: fix reference count leak in gpmi ops
Date: Thu, 19 Nov 2020 22:20:41 +0100 [thread overview]
Message-ID: <20201119212041.8122-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20201107110552.1568742-1-zhangqilong3@huawei.com>
On Sat, 2020-11-07 at 11:05:52 UTC, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage at first and it
> will resume the device later. If runtime of the device has
> error or device is in inaccessible state(or other error state),
> resume operation will fail. If we do not call put operation to
> decrease the reference, it will result in reference leak in
> the two functions(gpmi_init and gpmi_nfc_exec_op). Moreover,
> this device cannot enter the idle state and always stay busy or
> other non-idle state later. So we fixed it through adding
> pm_runtime_put_noidle.
>
> Fixes: 5bc6bb603b4d0 ("mtd: rawnand: gpmi: Fix suspend/resume problem")
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> Acked-by: Han Xu <han.xu@nxp.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2020-11-19 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 11:05 [PATCH] mtd: rawnand: gpmi: fix reference count leak in gpmi ops Zhang Qilong
2020-11-09 23:23 ` Han Xu
2020-11-19 21:20 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119212041.8122-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=han.xu@nxp.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.