All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@redhat.com>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: check the return value of krealloc() in xfs_uuid_mount
Date: Thu, 26 Nov 2020 11:13:54 +0800	[thread overview]
Message-ID: <20201126031354.GA345905@xiangao.remote.csb> (raw)
In-Reply-To: <5d6b6f6f-4bc3-2821-d5b1-569afba0221a@huawei.com>

On Thu, Nov 26, 2020 at 11:05:03AM +0800, Qinglang Miao wrote:

...

> > 
> > I'm not sure if Hulk CI is completely broken or not on this, also if
> > such CI can now generate trivial patch (?) since the subject, commit
> > message and even the variable name is quite similiar to
> > https://lore.kernel.org/linux-xfs/20201124104531.561-2-thunder.leizhen@huawei.com
> > in a day.
> > 
> > And it'd be better to look into the code before sending patches...
> Yeah..  I should pay more attension.

Yeah, it'd be better to address/fix the Hulk CI false report
if possible, so it won't have such warning in the future.

Thanks,
Gao Xiang

> > 
> > Thanks,
> > Gao Xiang >
> Thanks for your advice~
> > > 
> > > Thanks for your advice！
> > > 
> > 
> > .
> > 
> 


      reply	other threads:[~2020-11-26  3:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  6:50 [PATCH] xfs: check the return value of krealloc() in xfs_uuid_mount Qinglang Miao
2020-11-25 15:55 ` Eric Sandeen
2020-11-26  1:21   ` Qinglang Miao
2020-11-26  2:16     ` Gao Xiang
2020-11-26  3:05       ` Qinglang Miao
2020-11-26  3:13         ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126031354.GA345905@xiangao.remote.csb \
    --to=hsiangkao@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=miaoqinglang@huawei.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.