From: Leon Romanovsky <leon@kernel.org>
To: Weihang Li <liweihang@huawei.com>
Cc: dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH for-next 3/3] RDMA/hns: Refactor process of setting extended sge
Date: Tue, 1 Dec 2020 07:56:47 +0200 [thread overview]
Message-ID: <20201201055647.GF3286@unreal> (raw)
In-Reply-To: <1606558959-48510-4-git-send-email-liweihang@huawei.com>
On Sat, Nov 28, 2020 at 06:22:39PM +0800, Weihang Li wrote:
> The variable 'cnt' is used to represent the max number of sge an SQ WQE can
> use at first, then it means how many extended sge an SQ has. In addition,
> this function has no need to return a value. So refactor and encapsulate
> the parts of getting number of extended sge a WQE can use to make it easier
> to understand.
>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_qp.c | 60 +++++++++++++++------------------
> 1 file changed, 28 insertions(+), 32 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2020-12-01 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 10:22 [PATCH for-next 0/3] RDMA/hns: Fixes for calculation of sge Weihang Li
2020-11-28 10:22 ` [PATCH for-next 1/3] RDMA/hns: Fix 0-length sge calculation error Weihang Li
2020-12-01 5:56 ` Leon Romanovsky
2020-11-28 10:22 ` [PATCH for-next 2/3] RDMA/hns: Bugfix for calculation of extended sge Weihang Li
2020-12-01 5:56 ` Leon Romanovsky
2020-11-28 10:22 ` [PATCH for-next 3/3] RDMA/hns: Refactor process of setting " Weihang Li
2020-12-01 5:56 ` Leon Romanovsky [this message]
2020-12-02 1:02 ` [PATCH for-next 0/3] RDMA/hns: Fixes for calculation of sge Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201055647.GF3286@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.