From: Steven Rostedt <rostedt@goodmis.org>
To: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Cc: Beniamin Sandu <beniaminsandu@gmail.com>,
Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH v2] trace-cmd: make it build against musl C library
Date: Tue, 1 Dec 2020 16:35:29 -0500 [thread overview]
Message-ID: <20201201163529.2e4ad0d2@gandalf.local.home> (raw)
In-Reply-To: <CAPpZLN50X6=8nz3U2M6mk+KqDfxcwdr86d-6bHuV_rkphc1Xhw@mail.gmail.com>
On Mon, 30 Nov 2020 18:24:05 +0200
Tzvetomir Stoyanov <tz.stoyanov@gmail.com> wrote:
> On Mon, Nov 30, 2020 at 2:31 PM Beniamin Sandu <beniaminsandu@gmail.com> wrote:
> >
> > * add some missing headers and macros
> > * set pthread affinity using pthread_setaffinity_np after creating the thread
> > instead of pthread_attr_setaffinity_np (which seems to not be implemented
> > in musl)
> >
> > Tested using https://musl.cc/x86_64-linux-musl-native.tgz
> >
> > Signed-off-by: Beniamin Sandu <beniaminsandu@gmail.com>
>
> Thanks Beniamin!
> There is one minor coding style error, as we are using the kernel's
> coding style.
> No need to send another version, we will fix it when pulling the patch.
> Also, note that we are moving the libtracefs in its own repo:
> https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
> I'm going to port the libtracefs part of your patch to that repo too.
>
> Reviewed-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
>
I applied this. Thanks Beniamin and Tzvetomir!
-- Steve
prev parent reply other threads:[~2020-12-01 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:27 [PATCH v2] trace-cmd: make it build against musl C library Beniamin Sandu
2020-11-30 16:24 ` Tzvetomir Stoyanov
2020-12-01 21:35 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201163529.2e4ad0d2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=beniaminsandu@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=tz.stoyanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.