From: Kalle Valo <kvalo@codeaurora.org>
To: Sven Eckelmann <sven@narfation.org>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ath11k: Don't cast ath11k_skb_cb to ieee80211_tx_info.control
Date: Wed, 2 Dec 2020 18:19:34 +0000 (UTC) [thread overview]
Message-ID: <20201202181934.483D9C43461@smtp.codeaurora.org> (raw)
In-Reply-To: <20201119154235.263250-1-sven@narfation.org>
Sven Eckelmann <sven@narfation.org> wrote:
> The driver_data area of ieee80211_tx_info is used in ath11k for
> ath11k_skb_cb. The first function in the TX patch which rewrites it to
> ath11k_skb_cb is already ath11k_mac_op_tx. No one else in the code path
> must use it for something else before it reinitializes it. Otherwise the
> data has to be considered uninitialized or corrupt.
>
> But the ieee80211_tx_info.control shares exactly the same area as
> ieee80211_tx_info.driver_data and ath11k is still using it. This results in
> best case in a
>
> ath11k c000000.wifi1: no vif found for mgmt frame, flags 0x0
>
> or (slightly worse) in a kernel oops.
>
> Instead, the interesting data must be moved first into the ath11k_skb_cb
> and ieee80211_tx_info.control must then not be used anymore.
>
> Tested-on: IPQ8074 hw2.0 WLAN.HK.2.4.0.1.r1-00026-QCAHKSWPL_SILICONZ-2
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
3 patches applied to ath-next branch of ath.git, thanks.
f4d291b43f80 ath11k: Don't cast ath11k_skb_cb to ieee80211_tx_info.control
5da7acfec5ec ath11k: Reset ath11k_skb_cb before setting new flags
d35d1375493b ath11k: Build check size of ath11k_skb_cb
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201119154235.263250-1-sven@narfation.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2020-12-02 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 15:42 [PATCH v2 1/3] ath11k: Don't cast ath11k_skb_cb to ieee80211_tx_info.control Sven Eckelmann
2020-11-19 15:42 ` Sven Eckelmann
2020-11-19 15:42 ` [PATCH v2 2/3] ath11k: Reset ath11k_skb_cb before setting new flags Sven Eckelmann
2020-11-19 15:42 ` Sven Eckelmann
2020-11-19 15:42 ` [PATCH v2 3/3] ath11k: Build check size of ath11k_skb_cb Sven Eckelmann
2020-11-19 15:42 ` Sven Eckelmann
2020-12-02 18:19 ` [PATCH v2 1/3] ath11k: Don't cast ath11k_skb_cb to ieee80211_tx_info.control Kalle Valo
2020-12-02 18:19 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202181934.483D9C43461@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.