Re: [PATCH 1/3] xfs_quota: document how the default quota is stored

From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] xfs_quota: document how the default quota is stored
Date: Thu, 3 Dec 2020 12:38:00 -0800	[thread overview]
Message-ID: <20201203203800.GM106272@magnolia> (raw)
In-Reply-To: <8e0e818a-4e39-6a9b-fe89-19d786b82f12@redhat.com>

On Thu, Dec 03, 2020 at 02:12:58PM -0600, Eric Sandeen wrote:
> On 12/3/20 2:07 PM, Darrick J. Wong wrote:
> > On Thu, Dec 03, 2020 at 02:00:01PM -0600, Eric Sandeen wrote:
> >> Nowhere in the man page is the default quota described; what it
> >> does or where it is stored.  Add some brief information about this.
> >>
> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> >> ---
> >>  man/man8/xfs_quota.8 | 5 +++++
> >>  1 file changed, 5 insertions(+)
> >>
> >> diff --git a/man/man8/xfs_quota.8 b/man/man8/xfs_quota.8
> >> index dd0479cd..b3c4108e 100644
> >> --- a/man/man8/xfs_quota.8
> >> +++ b/man/man8/xfs_quota.8
> >> @@ -178,6 +178,11 @@ to a file on
> >>  where the user's quota has not been exceeded.
> >>  Then after rectifying the quota situation, the file can be moved back to the
> >>  filesystem it belongs on.
> >> +.SS Default Quotas
> >> +The XFS quota subsystem allows a default quota to be enforced for any user which
> > 
> > "user"?  Does this not apply to group or project quotas? ;)
> 
> I thought about that, but the overview section already refers to "users" as a
> generic idea, i.e. "Quotas can be set for each individual user on any/all of the
> local filesystems."
> 
> I mean, I guess I could s/user/ID/ to be more clear or rewrite the whole overview...

<shrug> "The XFS quota subsystem allows a default quota to be enforced
for any user, group or project which does not have a quota limit
explicitly set."

> >> +does not have a quota limit explicitly set. These limits are stored in and

"These limits are stored in and displayed as ID 0's limits."

since id==0 doesn't necessarily map to "root" unless
/etc/{passwd,group,projid} explicitly defines that.

--D

> > 
> > Usual complaint about starting sentences in column zero in manpage
> > source. :)
> 
> grumble grumble random nonobvious rules grumble ok
> 
> -Eric
> 
> > --D
> > 
> >> +displayed as the "root" user's limits, although they do not actually limit the
> >> +root user.
> >>  .SH USER COMMANDS
> >>  .TP
> >>  .B print
> >> -- 
> >> 2.17.0
> >>
> >>
> > 
> 